From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH bpf-next 00/14] nfp: bpf: add updates, deletes, atomic
 ops, prandom and packet cache
Date: Wed, 28 Mar 2018 19:45:19 -0700
Message-ID: <20180329024518.tfwzdohuf34n3hxp@ast-mbp>
References: <20180329004839.4506-1-jakub.kicinski@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: daniel@iogearbox.net, netdev@vger.kernel.org,
        oss-drivers@netronome.com, Jan Gossens <jan.gossens@rwth-aachen.de>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f181.google.com ([209.85.192.181]:40399 "EHLO
        mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750881AbeC2CpX (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 28 Mar 2018 22:45:23 -0400
Received: by mail-pf0-f181.google.com with SMTP id y66so2202379pfi.7
        for <netdev@vger.kernel.org>; Wed, 28 Mar 2018 19:45:23 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180329004839.4506-1-jakub.kicinski@netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Mar 28, 2018 at 05:48:24PM -0700, Jakub Kicinski wrote:
> Hi!
> 
> This set adds support for update and delete calls from the datapath,
> as well as XADD instructions (32 and 64 bit) and pseudo random numbers.
> The XADD support depends on verifier enforcing alignment which Daniel
> recently added.  XADD uses NFP's atomic engine which requires values
> to be in big endian, therefore we need to keep track of which parts of
> the values are used as atomics and byte swap them accordingly.  Pseudo
> random numbers are generated using NFP's HW pseudo random number
> generator.
> 
> Jiong tackles initial implementation of packet cache, which he describes
> as follows:
> 
> Memory reads on NFP would first fetch data from memory to transfer-in
> registers, then move them from transfer-in to general registers.
> 
> Given NFP is rich on transfer-in registers, they could serve as memory
> cache.
> 
> This patch tries to identify a sequence of packet data read (BPF_LDX) that
> are executed sequentially, then the total access range of the sequence is
> calculated and attached to each read instruction, the first instruction
> in this sequence is marked with an cache init flag so the execution of
> it would bring in the whole range of packet data for the sequence.
> 
> All later packet reads in this sequence would fetch data from transfer-in
> registers directly, no need to JIT NFP memory access.
> 
> Function call, non-packet-data memory read, packet write and memcpy will
> invalidate the cache and start a new cache range.
> 
> Cache invalidation could be improved in the future, for example packet
> write doesn't need to invalidate the cache if the the write destination
> won't be read again.

Looks exciting.
Applied to bpf-next, thank you Jakub.