From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH V17 3/4] eal/linux: uevent parse and process Date: Thu, 29 Mar 2018 09:59:40 -0700 Message-ID: <20180329095940.14205ef9@xeon-e3> References: <1522063256-3997-5-git-send-email-jia.guo@intel.com> <1522339205-27698-1-git-send-email-jia.guo@intel.com> <1522339205-27698-4-git-send-email-jia.guo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, harry.van.haaren@intel.com, jianfeng.tan@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com To: Jeff Guo Return-path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 2CD60231E for ; Thu, 29 Mar 2018 18:59:45 +0200 (CEST) Received: by mail-pf0-f173.google.com with SMTP id g14so3643635pfh.3 for ; Thu, 29 Mar 2018 09:59:44 -0700 (PDT) In-Reply-To: <1522339205-27698-4-git-send-email-jia.guo@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 30 Mar 2018 00:00:04 +0800 Jeff Guo wrote: > + ret = ioctl(netlink_fd, FIONBIO, &nonblock); > + if (ret != 0) { > + RTE_LOG(ERR, EAL, "ioctl(FIONBIO) failed.\n"); > + goto err; > + } > + retu Since you use NOWAIT option, this is unnecessary.