From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v4 04/13] usb: typec: add fwnode to tcpc Date: Thu, 29 Mar 2018 15:57:45 +0300 Message-ID: <20180329125745.GA19020@kuha.fi.intel.com> References: <1522253178-32414-1-git-send-email-jun.li@nxp.com> <1522253178-32414-5-git-send-email-jun.li@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1522253178-32414-5-git-send-email-jun.li@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Li Jun Cc: devel@driverdev.osuosl.org, peter.chen@nxp.com, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, a.hajda@samsung.com, robh+dt@kernel.org, linux-imx@nxp.com, linux@roeck-us.net, shufan_lee@richtek.com List-Id: devicetree@vger.kernel.org Hi, On Thu, Mar 29, 2018 at 12:06:09AM +0800, Li Jun wrote: > Add fwnode handle to get the fwnode so we can get typec configs > it contains. > > Suggested-by: Heikki Krogerus > Signed-off-by: Li Jun > --- > drivers/staging/typec/tcpci.c | 14 +++++++------- > drivers/usb/typec/tcpm.c | 1 + > include/linux/usb/tcpm.h | 2 ++ > 3 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c > index ed76327..4f7ad10 100644 > --- a/drivers/staging/typec/tcpci.c > +++ b/drivers/staging/typec/tcpci.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -463,17 +464,16 @@ static const struct regmap_config tcpci_regmap_config = { > .max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */ > }; > > -static const struct tcpc_config tcpci_tcpc_config = { > - .type = TYPEC_PORT_DFP, > - .default_role = TYPEC_SINK, > -}; > - > static int tcpci_parse_config(struct tcpci *tcpci) > { > tcpci->controls_vbus = true; /* XXX */ > > - /* TODO: Populate struct tcpc_config from ACPI/device-tree */ > - tcpci->tcpc.config = &tcpci_tcpc_config; That will break bisectablitity. tcpm.c is still accessing the config at this point. Just leave those untouched in here, and clean-up in separate patch that comes after the patch that prepares tcpm.c. Thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,04/13] usb: typec: add fwnode to tcpc From: Heikki Krogerus Message-Id: <20180329125745.GA19020@kuha.fi.intel.com> Date: Thu, 29 Mar 2018 15:57:45 +0300 To: Li Jun Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com, devel@driverdev.osuosl.org List-ID: SGksCgpPbiBUaHUsIE1hciAyOSwgMjAxOCBhdCAxMjowNjowOUFNICswODAwLCBMaSBKdW4gd3Jv dGU6Cj4gQWRkIGZ3bm9kZSBoYW5kbGUgdG8gZ2V0IHRoZSBmd25vZGUgc28gd2UgY2FuIGdldCB0 eXBlYyBjb25maWdzCj4gaXQgY29udGFpbnMuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBIZWlra2kgS3Jv Z2VydXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog TGkgSnVuIDxqdW4ubGlAbnhwLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9zdGFnaW5nL3R5cGVjL3Rj cGNpLmMgfCAxNCArKysrKysrLS0tLS0tLQo+ICBkcml2ZXJzL3VzYi90eXBlYy90Y3BtLmMgICAg ICB8ICAxICsKPiAgaW5jbHVkZS9saW51eC91c2IvdGNwbS5oICAgICAgfCAgMiArKwo+ICAzIGZp bGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jIGIvZHJpdmVycy9zdGFnaW5nL3R5 cGVjL3RjcGNpLmMKPiBpbmRleCBlZDc2MzI3Li40ZjdhZDEwIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jCj4gKysrIGIvZHJpdmVycy9zdGFnaW5nL3R5cGVjL3Rj cGNpLmMKPiBAQCAtMTAsNiArMTAsNyBAQAo+ICAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4g ICNpbmNsdWRlIDxsaW51eC9pMmMuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+ ICsjaW5jbHVkZSA8bGludXgvcHJvcGVydHkuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5o Pgo+ICAjaW5jbHVkZSA8bGludXgvdXNiL3BkLmg+Cj4gICNpbmNsdWRlIDxsaW51eC91c2IvdGNw bS5oPgo+IEBAIC00NjMsMTcgKzQ2NCwxNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJlZ21hcF9j b25maWcgdGNwY2lfcmVnbWFwX2NvbmZpZyA9IHsKPiAgCS5tYXhfcmVnaXN0ZXIgPSAweDdGLCAv KiAweDgwIC4uIDB4RkYgYXJlIHZlbmRvciBkZWZpbmVkICovCj4gIH07Cj4gIAo+IC1zdGF0aWMg Y29uc3Qgc3RydWN0IHRjcGNfY29uZmlnIHRjcGNpX3RjcGNfY29uZmlnID0gewo+IC0JLnR5cGUg PSBUWVBFQ19QT1JUX0RGUCwKPiAtCS5kZWZhdWx0X3JvbGUgPSBUWVBFQ19TSU5LLAo+IC19Owo+ IC0KPiAgc3RhdGljIGludCB0Y3BjaV9wYXJzZV9jb25maWcoc3RydWN0IHRjcGNpICp0Y3BjaSkK PiAgewo+ICAJdGNwY2ktPmNvbnRyb2xzX3ZidXMgPSB0cnVlOyAvKiBYWFggKi8KPiAgCj4gLQkv KiBUT0RPOiBQb3B1bGF0ZSBzdHJ1Y3QgdGNwY19jb25maWcgZnJvbSBBQ1BJL2RldmljZS10cmVl ICovCj4gLQl0Y3BjaS0+dGNwYy5jb25maWcgPSAmdGNwY2lfdGNwY19jb25maWc7CgpUaGF0IHdp bGwgYnJlYWsgYmlzZWN0YWJsaXRpdHkuIHRjcG0uYyBpcyBzdGlsbCBhY2Nlc3NpbmcgdGhlIGNv bmZpZwphdCB0aGlzIHBvaW50LgoKSnVzdCBsZWF2ZSB0aG9zZSB1bnRvdWNoZWQgaW4gaGVyZSwg YW5kIGNsZWFuLXVwIGluIHNlcGFyYXRlIHBhdGNoCnRoYXQgY29tZXMgYWZ0ZXIgdGhlIHBhdGNo IHRoYXQgcHJlcGFyZXMgdGNwbS5jLgoKClRoYW5rcywK