From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH v2 2/4] drm/i915: Read Vprime thrice incase
 of mismatch
Date: Thu, 29 Mar 2018 10:38:46 -0400
Message-ID: <20180329143846.GD41885@art_vandelay>
References: <1522332548-15370-1-git-send-email-ramalingam.c@intel.com>
 <1522332548-15370-3-git-send-email-ramalingam.c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1522332548-15370-3-git-send-email-ramalingam.c@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBNYXIgMjksIDIwMTggYXQgMDc6Mzk6MDZQTSArMDUzMCwgUmFtYWxpbmdhbSBDIHdy
b3RlOgo+IEluIGNhc2Ugb2YgViBwcmltZSBtaXNtYXRjaCwgRFAgSERDUCBzcGVjIG1hbmRhdGVz
IHRoZSByZS1yZWFkIG9mCj4gVnByaW1lIGF0bGVhc3QgdHdpY2UuCj4gCj4gVGhpcyBwYXRjaCBu
ZWVkZWQgZm9yIERQIEhEQ1AxLjQgQ1RTIFRlc3Q6IDFCLTA1Lgo+IAo+IHYyOgo+ICAgTW92ZWQg
dGhlIFYnIHZhbGlkYXRpb24gaW50byBhIGZ1bmN0aW9uIGZvciByZXRyeS4gW1NlYW4gUGF1bF0K
PiAKPiBTaWduZWQtb2ZmLWJ5OiBSYW1hbGluZ2FtIEMgPHJhbWFsaW5nYW0uY0BpbnRlbC5jb20+
Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkY3AuYyB8IDExMyArKysrKysr
KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNzAgaW5z
ZXJ0aW9ucygrKSwgNDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2hkY3AuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkY3Au
Ywo+IGluZGV4IDk2YjkwMjVkYzc1OS4uZjc3ZDk1NmIyYjE4IDEwMDY0NAo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkY3AuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2hkY3AuYwo+IEBAIC0xNDIsNTMgKzE0MiwxNyBAQCBib29sIGludGVsX2hkY3BfaXNf
a3N2X3ZhbGlkKHU4ICprc3YpCj4gIAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiAtLyogSW1wbGVt
ZW50cyBQYXJ0IDIgb2YgdGhlIEhEQ1AgYXV0aG9yaXphdGlvbiBwcm9jZWR1cmUgKi8KPiAtc3Rh
dGljCj4gLWludCBpbnRlbF9oZGNwX2F1dGhfZG93bnN0cmVhbShzdHJ1Y3QgaW50ZWxfZGlnaXRh
bF9wb3J0ICppbnRlbF9kaWdfcG9ydCwKPiAtCQkJICAgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9o
ZGNwX3NoaW0gKnNoaW0pCj4gK3N0YXRpYyBpbmxpbmUKCldoeSBpbmxpbmU/Cgo+ICtpbnQgaW50
ZWxfaGRjcF92YWxpZGF0ZV92X3ByaW1lKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVs
X2RpZ19wb3J0LAo+ICsJCQkJY29uc3Qgc3RydWN0IGludGVsX2hkY3Bfc2hpbSAqc2hpbSwKPiAr
CQkJCXU4ICprc3ZfZmlmbywgdTggbnVtX2Rvd25zdHJlYW0sIHU4ICpic3RhdHVzKQo+ICB7Cj4g
IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXY7Cj4gIAl1MzIgdnByaW1lLCBzaGFf
dGV4dCwgc2hhX2xlZnRvdmVycywgcmVwX2N0bDsKPiAtCXU4IGJzdGF0dXNbMl0sIG51bV9kb3du
c3RyZWFtLCAqa3N2X2ZpZm87Cj4gIAlpbnQgcmV0LCBpLCBqLCBzaGFfaWR4Owo+ICAKPiAgCWRl
dl9wcml2ID0gaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYtPmRldl9wcml2YXRlOwo+ICAK
PiAtCXJldCA9IGludGVsX2hkY3BfcG9sbF9rc3ZfZmlmbyhpbnRlbF9kaWdfcG9ydCwgc2hpbSk7
Cj4gLQlpZiAocmV0KSB7Cj4gLQkJRFJNX0VSUk9SKCJLU1YgbGlzdCBmYWlsZWQgdG8gYmVjb21l
IHJlYWR5ICglZClcbiIsIHJldCk7Cj4gLQkJcmV0dXJuIHJldDsKPiAtCX0KPiAtCj4gLQlyZXQg
PSBzaGltLT5yZWFkX2JzdGF0dXMoaW50ZWxfZGlnX3BvcnQsIGJzdGF0dXMpOwo+IC0JaWYgKHJl
dCkKPiAtCQlyZXR1cm4gcmV0Owo+IC0KPiAtCWlmIChEUk1fSERDUF9NQVhfREVWSUNFX0VYQ0VF
REVEKGJzdGF0dXNbMF0pIHx8Cj4gLQkgICAgRFJNX0hEQ1BfTUFYX0NBU0NBREVfRVhDRUVERUQo
YnN0YXR1c1sxXSkpIHsKPiAtCQlEUk1fRVJST1IoIk1heCBUb3BvbG9neSBMaW1pdCBFeGNlZWRl
ZFxuIik7Cj4gLQkJcmV0dXJuIC1FUEVSTTsKPiAtCX0KPiAtCj4gLQkvKgo+IC0JICogV2hlbiBy
ZXBlYXRlciByZXBvcnRzIDAgZGV2aWNlIGNvdW50LCBIRENQMS40IHNwZWMgYWxsb3dzIGRpc2Fi
bGluZwo+IC0JICogdGhlIEhEQ1AgZW5jcnlwdGlvbi4gVGhhdCBpbXBsaWVzIHRoYXQgcmVwZWF0
ZXIgY2FuJ3QgaGF2ZSBpdHMgb3duCj4gLQkgKiBkaXNwbGF5LiBBcyB0aGVyZSBpcyBubyBjb25z
dW1wdGlvbiBvZiBlbmNyeXB0ZWQgY29udGVudCBpbiB0aGUKPiAtCSAqIHJlcGVhdGVyIHdpdGgg
MCBkb3duc3RyZWFtIGRldmljZXMsIHdlIGFyZSBmYWlsaW5nIHRoZQo+IC0JICogYXV0aGVudGlj
YXRpb24uCj4gLQkgKi8KPiAtCW51bV9kb3duc3RyZWFtID0gRFJNX0hEQ1BfTlVNX0RPV05TVFJF
QU0oYnN0YXR1c1swXSk7Cj4gLQlpZiAobnVtX2Rvd25zdHJlYW0gPT0gMCkKPiAtCQlyZXR1cm4g
LUVJTlZBTDsKPiAtCj4gLQlrc3ZfZmlmbyA9IGt6YWxsb2MobnVtX2Rvd25zdHJlYW0gKiBEUk1f
SERDUF9LU1ZfTEVOLCBHRlBfS0VSTkVMKTsKPiAtCWlmICgha3N2X2ZpZm8pCj4gLQkJcmV0dXJu
IC1FTk9NRU07Cj4gLQo+IC0JcmV0ID0gc2hpbS0+cmVhZF9rc3ZfZmlmbyhpbnRlbF9kaWdfcG9y
dCwgbnVtX2Rvd25zdHJlYW0sIGtzdl9maWZvKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJl
dDsKPiAtCj4gIAkvKiBQcm9jZXNzIFYnIHZhbHVlcyBmcm9tIHRoZSByZWNlaXZlciAqLwo+ICAJ
Zm9yIChpID0gMDsgaSA8IERSTV9IRENQX1ZfUFJJTUVfTlVNX1BBUlRTOyBpKyspIHsKPiAgCQly
ZXQgPSBzaGltLT5yZWFkX3ZfcHJpbWVfcGFydChpbnRlbF9kaWdfcG9ydCwgaSwgJnZwcmltZSk7
Cj4gQEAgLTM1Myw3ICszMTcsNyBAQCBpbnQgaW50ZWxfaGRjcF9hdXRoX2Rvd25zdHJlYW0oc3Ry
dWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gIAkJCXJldHVybiByZXQ7
Cj4gIAkJc2hhX2lkeCArPSBzaXplb2Yoc2hhX3RleHQpOwo+ICAJfSBlbHNlIHsKPiAtCQlEUk1f
RVJST1IoIkludmFsaWQgbnVtYmVyIG9mIGxlZnRvdmVycyAlZFxuIiwgc2hhX2xlZnRvdmVycyk7
Cj4gKwkJRFJNX0RFQlVHKCJJbnZhbGlkIG51bWJlciBvZiBsZWZ0b3ZlcnMgJWRcbiIsIHNoYV9s
ZWZ0b3ZlcnMpOwo+ICAJCXJldHVybiAtRUlOVkFMOwo+ICAJfQo+ICAKPiBAQCAtMzgxLDE0ICsz
NDUsNzcgQEAgaW50IGludGVsX2hkY3BfYXV0aF9kb3duc3RyZWFtKHN0cnVjdCBpbnRlbF9kaWdp
dGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ICAJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVy
KGRldl9wcml2LCBIRENQX1JFUF9DVEwsCj4gIAkJCQkgICAgSERDUF9TSEExX0NPTVBMRVRFLAo+
ICAJCQkJICAgIEhEQ1BfU0hBMV9DT01QTEVURSwgMSkpIHsKPiAtCQlEUk1fRVJST1IoIlRpbWVk
IG91dCB3YWl0aW5nIGZvciBTSEExIGNvbXBsZXRlXG4iKTsKPiArCQlEUk1fREVCVUcoIlRpbWVk
IG91dCB3YWl0aW5nIGZvciBTSEExIGNvbXBsZXRlXG4iKTsKPiAgCQlyZXR1cm4gLUVUSU1FRE9V
VDsKPiAgCX0KPiAgCWlmICghKEk5MTVfUkVBRChIRENQX1JFUF9DVEwpICYgSERDUF9TSEExX1Zf
TUFUQ0gpKSB7Cj4gLQkJRFJNX0VSUk9SKCJTSEEtMSBtaXNtYXRjaCwgSERDUCBmYWlsZWRcbiIp
Owo+ICsJCURSTV9ERUJVRygiU0hBLTEgbWlzbWF0Y2gsIEhEQ1AgZmFpbGVkXG4iKTsKCkkgdGhp
bmsgdGhlIERFQlVHIHNob3VsZCBiZSBERUJVR19LTVMsIGNvbnNpc3RlbnQgd2l0aCB0aGUgcmVz
dCBvZiB0aGUgZmlsZT8KCj4gIAkJcmV0dXJuIC1FTlhJTzsKPiAgCX0KPiAgCj4gKwlyZXR1cm4g
MDsKPiArfQo+ICsKPiArLyogSW1wbGVtZW50cyBQYXJ0IDIgb2YgdGhlIEhEQ1AgYXV0aG9yaXph
dGlvbiBwcm9jZWR1cmUgKi8KPiArc3RhdGljCj4gK2ludCBpbnRlbF9oZGNwX2F1dGhfZG93bnN0
cmVhbShzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCwKPiArCQkJICAg
ICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9oZGNwX3NoaW0gKnNoaW0pCj4gK3sKPiArCXU4IGJzdGF0
dXNbMl0sIG51bV9kb3duc3RyZWFtLCAqa3N2X2ZpZm87Cj4gKwlpbnQgcmV0LCBpLCB0cmllcyA9
IDM7Cj4gKwo+ICsJcmV0ID0gaW50ZWxfaGRjcF9wb2xsX2tzdl9maWZvKGludGVsX2RpZ19wb3J0
LCBzaGltKTsKPiArCWlmIChyZXQpIHsKPiArCQlEUk1fRVJST1IoIktTViBsaXN0IGZhaWxlZCB0
byBiZWNvbWUgcmVhZHkgKCVkKVxuIiwgcmV0KTsKPiArCQlyZXR1cm4gcmV0Owo+ICsJfQo+ICsK
PiArCXJldCA9IHNoaW0tPnJlYWRfYnN0YXR1cyhpbnRlbF9kaWdfcG9ydCwgYnN0YXR1cyk7Cj4g
KwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJaWYgKERSTV9IRENQX01BWF9ERVZJ
Q0VfRVhDRUVERUQoYnN0YXR1c1swXSkgfHwKPiArCSAgICBEUk1fSERDUF9NQVhfQ0FTQ0FERV9F
WENFRURFRChic3RhdHVzWzFdKSkgewo+ICsJCURSTV9FUlJPUigiTWF4IFRvcG9sb2d5IExpbWl0
IEV4Y2VlZGVkXG4iKTsKPiArCQlyZXR1cm4gLUVQRVJNOwo+ICsJfQo+ICsKPiArCS8qCj4gKwkg
KiBXaGVuIHJlcGVhdGVyIHJlcG9ydHMgMCBkZXZpY2UgY291bnQsIEhEQ1AxLjQgc3BlYyBhbGxv
d3MgZGlzYWJsaW5nCj4gKwkgKiB0aGUgSERDUCBlbmNyeXB0aW9uLiBUaGF0IGltcGxpZXMgdGhh
dCByZXBlYXRlciBjYW4ndCBoYXZlIGl0cyBvd24KPiArCSAqIGRpc3BsYXkuIEFzIHRoZXJlIGlz
IG5vIGNvbnN1bXB0aW9uIG9mIGVuY3J5cHRlZCBjb250ZW50IGluIHRoZQo+ICsJICogcmVwZWF0
ZXIgd2l0aCAwIGRvd25zdHJlYW0gZGV2aWNlcywgd2UgYXJlIGZhaWxpbmcgdGhlCj4gKwkgKiBh
dXRoZW50aWNhdGlvbi4KPiArCSAqLwo+ICsJbnVtX2Rvd25zdHJlYW0gPSBEUk1fSERDUF9OVU1f
RE9XTlNUUkVBTShic3RhdHVzWzBdKTsKPiArCWlmIChudW1fZG93bnN0cmVhbSA9PSAwKQo+ICsJ
CXJldHVybiAtRUlOVkFMOwo+ICsKPiArCWtzdl9maWZvID0ga3phbGxvYyhudW1fZG93bnN0cmVh
bSAqIERSTV9IRENQX0tTVl9MRU4sIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFrc3ZfZmlmbykKPiAr
CQlyZXR1cm4gLUVOT01FTTsKPiArCj4gKwlyZXQgPSBzaGltLT5yZWFkX2tzdl9maWZvKGludGVs
X2RpZ19wb3J0LCBudW1fZG93bnN0cmVhbSwga3N2X2ZpZm8pOwo+ICsJaWYgKHJldCkKPiArCQly
ZXR1cm4gcmV0Owo+ICsKPiArCS8qCj4gKwkgKiBXaGVuIFYgcHJpbWUgbWlzbWF0Y2hlcywgRFAg
U3BlYyBtYW5kYXRlcyByZS1yZWFkIG9mCj4gKwkgKiBWIHByaW1lIGF0bGVhc3QgdHdpY2UuCj4g
KwkgKi8KPiArCWZvciAoaSA9IDA7IGkgPCB0cmllczsgaSsrKSB7Cj4gKwkJcmV0ID0gaW50ZWxf
aGRjcF92YWxpZGF0ZV92X3ByaW1lKGludGVsX2RpZ19wb3J0LCBzaGltLAo+ICsJCQkJCQkgIGtz
dl9maWZvLCBudW1fZG93bnN0cmVhbSwKPiArCQkJCQkJICBic3RhdHVzKTsKPiArCQlpZiAoIXJl
dCkKPiArCQkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJaWYgKGkgPT0gdHJpZXMpIHsKPiArCQlEUk1f
RVJST1IoIlYgUHJpbWUgdmFsaWRhdGlvbiBmYWlsZWQuKCVkKVxuIiwgcmV0KTsKPiArCQlyZXR1
cm4gcmV0Owo+ICsJfQo+ICsKPiAgCURSTV9ERUJVR19LTVMoIkhEQ1AgaXMgZW5hYmxlZCAoJWQg
ZG93bnN0cmVhbSBkZXZpY2VzKVxuIiwKPiAgCQkgICAgICBudW1fZG93bnN0cmVhbSk7Cj4gIAly
ZXR1cm4gMDsKPiAtLSAKPiAyLjcuNAo+IAoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5l
ZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeAo=