From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Reichel Subject: Re: [PATCH 3/3] drm/omap: remove unused function Date: Thu, 29 Mar 2018 16:44:35 +0200 Message-ID: <20180329144435.tqanecil6kgvkjb7@earth.universe> References: <20180329104038.29154-1-tomi.valkeinen@ti.com> <20180329104038.29154-3-tomi.valkeinen@ti.com> <20180329123159.o7bmwmtvwixmdiuc@earth.universe> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1371370774==" Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id D52086E71B for ; Thu, 29 Mar 2018 14:44:39 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Emil Velikov , Laurent Pinchart , ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1371370774== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jq44623wobyedkun" Content-Disposition: inline --jq44623wobyedkun Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Mar 29, 2018 at 03:49:08PM +0300, Tomi Valkeinen wrote: > On 29/03/18 15:31, Sebastian Reichel wrote: > > Hi, > >=20 > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: > >> On 29 March 2018 at 11:40, Tomi Valkeinen wrot= e: > >>> omap_framebuffer_get_next_connector() is not used, remove it. > >>> > >> Seems to have been unused for a few years now. > >> Namely since commit 5a35876e2830511cb8110667fc426c6a6165a593 > >> > >> Reviewed-by: Emil Velikov > >=20 > > I have a pending patch using that function to basically restore the > > functionality from the referenced commit: >=20 > Oh, ok. I'll drop this patch. Thanks. > These was a Klocwork warning for this function, so the easiest fix > was to remove it. >=20 > drivers/gpu/drm/omapdrm/omap_fb.c:326 INFINITE_LOOP.LOCAL (2:Error) Analy= ze > Infinite loop > * omap_fb.c:326: Entering loop with precondition (from!=3D0) && > (connector!=3D0) && from =3D=3D connector This makes sense to me, since the code initializes connector to from and returns early if from is NULL. > * omap_fb.c:326: condition 0 is always false > * omap_fb.c:326: condition 0 is always false > * omap_fb.c:327: condition connector!=3Dfrom is always false Looks like list_for_each_entry_from() is not properly understood by the static checker? -- Sebastian --jq44623wobyedkun Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlq8+9AACgkQ2O7X88g7 +pq3yRAAojomyf//7yq01MdgoWI1K+prNvzO+b3E3W/WPH0KoWriFTiFHr3n7ijd KYaPUYQ8yn9yuoHQJ5MhIhvZf+LSOwArE0+kTufZ+Nx0rRQ0vtt0j7yn9TpPCKJh pSH4HfUobRhQztD1qZHc1dQHLKK9izAJFVy0I8Qu3tIpvZzcDRKHotCLBKUulWMg ZZURtsxtiVq+X/3HKdclaompJf82g8CgiDxa3vh6eUtFoh6Rlhm+EUaJ0o0rJ0Dh zL0jcm9Wkl9hGzzMExbbctb26ppZE1Z8PcQ8QqU1ElJm4pkuYwrM83nHJIG8AY9y Uztbz6xXkytvjNnAlYAQiA8FvVtKah/1Ct1JllOCpPxnBbAGXw+orNffqAURQiU0 i0y2KwSUTxCH+0wtpY6mUQRaqVooTMbx/fprpa3V0G9TCNcGK048jXrHf/eMYCcN aXcsb/V/rjANmULuTTgBJunmqdrIkqpkiDSjSLtil6GL3X9MlYS3i66Z7Mdh055f g4HYQEYWpAG0m5pKye5sFQwVTrwkFcaoPsLJv+DwZN/5rmA3bOBGc+p6pS8rqzbs 3V/LqKOYI+nwXBJCBSn+UIxy2hY+UopXw2JMQyhW2HrmU/kDfwAuiQ8wWdeAUbwC MNwVFCB03GI6Wui17Jnz3B9HAFwEbog5nv5WbW0a8qMdwBierRY= =V4+l -----END PGP SIGNATURE----- --jq44623wobyedkun-- --===============1371370774== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1371370774==--