From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446AbeC2QOn convert rfc822-to-8bit (ORCPT ); Thu, 29 Mar 2018 12:14:43 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:33806 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbeC2QOl (ORCPT ); Thu, 29 Mar 2018 12:14:41 -0400 Date: Thu, 29 Mar 2018 18:14:22 +0200 Message-ID: <20180329181422.Horde.4gvIQbpSZkuyC4Yzg06PKw2@messagerie.si.c-s.fr> From: LEROY Christophe To: Mathieu Malaterre Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Benjamin Herrenschmidt , Michael Ellerman Subject: Re: [PATCH v2 03/19] powerpc: Mark variables as unused References: <20180322202007.23088-4-malat@debian.org> <20180328193307.978-1-malat@debian.org> In-Reply-To: <20180328193307.978-1-malat@debian.org> User-Agent: Internet Messaging Program (IMP) H5 (6.2.3) Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mathieu Malaterre a écrit : > Add gcc attribute unused for two variables. Fix warnings treated as errors > with W=1: > > arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set > but not used [-Werror=unused-but-set-variable] > > Suggested-by: Christophe Leroy > Signed-off-by: Mathieu Malaterre > --- > v2: move path within ifdef DEBUG_PROM > > arch/powerpc/kernel/prom_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_init.c > b/arch/powerpc/kernel/prom_init.c > index acf4b2e0530c..4163b11abb6c 100644 > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -603,7 +603,7 @@ static void __init early_cmdline_parse(void) > const char *opt; > > char *p; > - int l = 0; > + int l __maybe_unused = 0; > > prom_cmd_line[0] = 0; > p = prom_cmd_line; > @@ -1385,7 +1385,7 @@ static void __init reserve_mem(u64 base, u64 size) > static void __init prom_init_mem(void) > { > phandle node; > - char *path, type[64]; > + char *path __maybe_unused, type[64]; You should enclose that in an ifdef DEBUG_PROM instead of hiding the warning Christophe > unsigned int plen; > cell_t *p, *endp; > __be32 val; > @@ -1406,7 +1406,6 @@ static void __init prom_init_mem(void) > prom_debug("root_size_cells: %x\n", rsc); > > prom_debug("scanning memory:\n"); > - path = prom_scratch; > > for (node = 0; prom_next_node(&node); ) { > type[0] = 0; > @@ -1431,6 +1430,7 @@ static void __init prom_init_mem(void) > endp = p + (plen / sizeof(cell_t)); > > #ifdef DEBUG_PROM > + path = prom_scratch; > memset(path, 0, PROM_SCRATCH_SIZE); > call_prom("package-to-path", 3, 1, node, path, PROM_SCRATCH_SIZE-1); > prom_debug(" node %s :\n", path); > -- > 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40BqZr5lVSzF0my for ; Fri, 30 Mar 2018 03:14:44 +1100 (AEDT) Date: Thu, 29 Mar 2018 18:14:22 +0200 Message-ID: <20180329181422.Horde.4gvIQbpSZkuyC4Yzg06PKw2@messagerie.si.c-s.fr> From: LEROY Christophe To: Mathieu Malaterre Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Benjamin Herrenschmidt , Michael Ellerman Subject: Re: [PATCH v2 03/19] powerpc: Mark variables as unused References: <20180322202007.23088-4-malat@debian.org> <20180328193307.978-1-malat@debian.org> In-Reply-To: <20180328193307.978-1-malat@debian.org> Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mathieu Malaterre a =C3=A9crit=C2=A0: > Add gcc attribute unused for two variables. Fix warnings treated as error= s > with W=3D1: > > arch/powerpc/kernel/prom_init.c:1388:8: error: variable =E2=80=98path= =E2=80=99 set=20=20 >=20but not used [-Werror=3Dunused-but-set-variable] > > Suggested-by: Christophe Leroy > Signed-off-by: Mathieu Malaterre > --- > v2: move path within ifdef DEBUG_PROM > > arch/powerpc/kernel/prom_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_init.c=20=20 >=20b/arch/powerpc/kernel/prom_init.c > index acf4b2e0530c..4163b11abb6c 100644 > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -603,7 +603,7 @@ static void __init early_cmdline_parse(void) > const char *opt; > > char *p; > - int l =3D 0; > + int l __maybe_unused =3D 0; > > prom_cmd_line[0] =3D 0; > p =3D prom_cmd_line; > @@ -1385,7 +1385,7 @@ static void __init reserve_mem(u64 base, u64 size) > static void __init prom_init_mem(void) > { > phandle node; > - char *path, type[64]; > + char *path __maybe_unused, type[64]; You should enclose that in an ifdef DEBUG_PROM instead of hiding the warnin= g Christophe > unsigned int plen; > cell_t *p, *endp; > __be32 val; > @@ -1406,7 +1406,6 @@ static void __init prom_init_mem(void) > prom_debug("root_size_cells: %x\n", rsc); > > prom_debug("scanning memory:\n"); > - path =3D prom_scratch; > > for (node =3D 0; prom_next_node(&node); ) { > type[0] =3D 0; > @@ -1431,6 +1430,7 @@ static void __init prom_init_mem(void) > endp =3D p + (plen / sizeof(cell_t)); > > #ifdef DEBUG_PROM > + path =3D prom_scratch; > memset(path, 0, PROM_SCRATCH_SIZE); > call_prom("package-to-path", 3, 1, node, path, PROM_SCRATCH_SIZE-1); > prom_debug(" node %s :\n", path); > -- > 2.11.0