* [PATCH] drm/edid: Dump valid EDIDs too
@ 2018-03-29 15:50 Ville Syrjala
2018-03-29 16:01 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ville Syrjala @ 2018-03-29 15:50 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Having the EDID available is often very beneficial for bug analysis,
even when the EDID itself is valid and not the direct cause of the
bug. So let's dump the EDID to dmesg even when it's valid. This
should also give us a better historical record of EDIDs for later
analysis.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_edid.c | 39 +++++++++++++++++++++++++++------------
1 file changed, 27 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 134069f36482..1153b2f74c58 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1517,17 +1517,27 @@ drm_do_probe_ddc_edid(void *data, u8 *buf, unsigned int block, size_t len)
return ret == xfers ? 0 : -1;
}
-static void connector_bad_edid(struct drm_connector *connector,
- u8 *edid, int num_blocks)
+static void connector_dump_edid(struct drm_connector *connector,
+ u8 *edid, int num_blocks,
+ bool valid)
{
int i;
- if (connector->bad_edid_counter++ && !(drm_debug & DRM_UT_KMS))
- return;
+ if (valid) {
+ if (!(drm_debug & DRM_UT_KMS))
+ return;
+
+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] EDID is valid:\n",
+ connector->base.id, connector->name);
+ } else {
+ if (connector->bad_edid_counter++ && !(drm_debug & DRM_UT_KMS))
+ return;
+
+ dev_warn(connector->dev->dev,
+ "[CONNECTOR:%d:%s] EDID is invalid:\n",
+ connector->base.id, connector->name);
+ }
- dev_warn(connector->dev->dev,
- "%s: EDID is invalid:\n",
- connector->name);
for (i = 0; i < num_blocks; i++) {
u8 *block = edid + i * EDID_LENGTH;
char prefix[20];
@@ -1539,7 +1549,7 @@ static void connector_bad_edid(struct drm_connector *connector,
else
sprintf(prefix, "\t[%02x] GOOD ", i);
- print_hex_dump(KERN_WARNING,
+ print_hex_dump(valid ? KERN_DEBUG : KERN_WARNING,
prefix, DUMP_PREFIX_NONE, 16, 1,
block, EDID_LENGTH, false);
}
@@ -1580,8 +1590,10 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
if (!override)
override = drm_load_edid_firmware(connector);
- if (!IS_ERR_OR_NULL(override))
- return override;
+ if (!IS_ERR_OR_NULL(override)) {
+ edid = (u8 *)override;
+ goto done;
+ }
if ((edid = kmalloc(EDID_LENGTH, GFP_KERNEL)) == NULL)
return NULL;
@@ -1628,7 +1640,7 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
if (valid_extensions != edid[0x7e]) {
u8 *base;
- connector_bad_edid(connector, edid, edid[0x7e] + 1);
+ connector_dump_edid(connector, edid, edid[0x7e] + 1, false);
edid[EDID_LENGTH-1] += edid[0x7e] - valid_extensions;
edid[0x7e] = valid_extensions;
@@ -1652,10 +1664,13 @@ struct edid *drm_do_get_edid(struct drm_connector *connector,
edid = new;
}
+done:
+ connector_dump_edid(connector, edid, edid[0x7e] + 1, true);
+
return (struct edid *)edid;
carp:
- connector_bad_edid(connector, edid, 1);
+ connector_dump_edid(connector, edid, 1, false);
out:
kfree(edid);
return NULL;
--
2.16.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/edid: Dump valid EDIDs too
2018-03-29 15:50 [PATCH] drm/edid: Dump valid EDIDs too Ville Syrjala
@ 2018-03-29 16:01 ` Chris Wilson
2018-03-29 16:14 ` Ville Syrjälä
2018-03-29 16:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-29 21:00 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-03-29 16:01 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: intel-gfx
Quoting Ville Syrjala (2018-03-29 16:50:23)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Having the EDID available is often very beneficial for bug analysis,
> even when the EDID itself is valid and not the direct cause of the
> bug. So let's dump the EDID to dmesg even when it's valid. This
> should also give us a better historical record of EDIDs for later
> analysis.
Isn't this a bit frequent for a largely unchanging blob?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/edid: Dump valid EDIDs too
2018-03-29 16:01 ` Chris Wilson
@ 2018-03-29 16:14 ` Ville Syrjälä
2018-03-29 16:47 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2018-03-29 16:14 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, dri-devel
On Thu, Mar 29, 2018 at 05:01:13PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-03-29 16:50:23)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Having the EDID available is often very beneficial for bug analysis,
> > even when the EDID itself is valid and not the direct cause of the
> > bug. So let's dump the EDID to dmesg even when it's valid. This
> > should also give us a better historical record of EDIDs for later
> > analysis.
>
> Isn't this a bit frequent for a largely unchanging blob?
Perhaps. Though ideally we shouldn't go re-reading it all the time.
But I guess that's wisful thinking.
Not sure we have a good place where we could memcmp() the new EDID
against the old one and only print if it changed.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/edid: Dump valid EDIDs too
2018-03-29 15:50 [PATCH] drm/edid: Dump valid EDIDs too Ville Syrjala
2018-03-29 16:01 ` Chris Wilson
@ 2018-03-29 16:40 ` Patchwork
2018-03-29 21:00 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-03-29 16:40 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/edid: Dump valid EDIDs too
URL : https://patchwork.freedesktop.org/series/40896/
State : success
== Summary ==
Series 40896v1 drm/edid: Dump valid EDIDs too
https://patchwork.freedesktop.org/api/1.0/series/40896/revisions/1/mbox/
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-b:
pass -> FAIL (fi-skl-guc) fdo#103191
Subgroup read-crc-pipe-b-frame-sequence:
fail -> PASS (fi-cfl-s3) fdo#103481
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:429s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:438s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:381s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:537s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:295s
fi-bxt-dsi total:243 pass:216 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:510s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:521s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:509s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:411s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:560s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:509s
fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:586s
fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:420s
fi-gdg-551 total:285 pass:177 dwarn:0 dfail:0 fail:0 skip:108 time:319s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:538s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:407s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:420s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:433s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:470s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:466s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:505s
fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:662s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:438s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:534s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:507s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:505s
fi-skl-guc total:285 pass:256 dwarn:0 dfail:0 fail:1 skip:28 time:427s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:444s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:406s
Blacklisted hosts:
fi-cnl-psr total:285 pass:256 dwarn:3 dfail:0 fail:0 skip:26 time:522s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:482s
d6e43ca115e525e6d53539be28100d2ee0958655 drm-tip: 2018y-03m-29d-12h-46m-03s UTC integration manifest
aaffa0db447e drm/edid: Dump valid EDIDs too
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8537/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/edid: Dump valid EDIDs too
2018-03-29 16:14 ` Ville Syrjälä
@ 2018-03-29 16:47 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-03-29 16:47 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, dri-devel
Quoting Ville Syrjälä (2018-03-29 17:14:05)
> On Thu, Mar 29, 2018 at 05:01:13PM +0100, Chris Wilson wrote:
> > Quoting Ville Syrjala (2018-03-29 16:50:23)
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Having the EDID available is often very beneficial for bug analysis,
> > > even when the EDID itself is valid and not the direct cause of the
> > > bug. So let's dump the EDID to dmesg even when it's valid. This
> > > should also give us a better historical record of EDIDs for later
> > > analysis.
> >
> > Isn't this a bit frequent for a largely unchanging blob?
>
> Perhaps. Though ideally we shouldn't go re-reading it all the time.
> But I guess that's wisful thinking.
Ok, that was far less frequent that I expected for an igt run, though it
does look like Maarten has a few more probes to kill.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/edid: Dump valid EDIDs too
2018-03-29 15:50 [PATCH] drm/edid: Dump valid EDIDs too Ville Syrjala
2018-03-29 16:01 ` Chris Wilson
2018-03-29 16:40 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-03-29 21:00 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-03-29 21:00 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/edid: Dump valid EDIDs too
URL : https://patchwork.freedesktop.org/series/40896/
State : success
== Summary ==
---- Known issues:
Test kms_flip:
Subgroup 2x-plain-flip-fb-recreate:
pass -> FAIL (shard-hsw) fdo#100368
Subgroup dpms-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#103060
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
incomplete -> PASS (shard-hsw) fdo#103375
Test kms_rotation_crc:
Subgroup primary-rotation-180:
pass -> FAIL (shard-hsw) fdo#103925
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
shard-apl total:3495 pass:1831 dwarn:1 dfail:0 fail:7 skip:1655 time:12884s
shard-hsw total:3495 pass:1780 dwarn:1 dfail:0 fail:4 skip:1709 time:11516s
shard-snb total:3495 pass:1374 dwarn:1 dfail:0 fail:3 skip:2117 time:7033s
Blacklisted hosts:
shard-kbl total:3495 pass:1910 dwarn:49 dfail:1 fail:7 skip:1528 time:9295s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8537/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-29 21:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-29 15:50 [PATCH] drm/edid: Dump valid EDIDs too Ville Syrjala
2018-03-29 16:01 ` Chris Wilson
2018-03-29 16:14 ` Ville Syrjälä
2018-03-29 16:47 ` Chris Wilson
2018-03-29 16:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-29 21:00 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.