From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 08/13] ASoC: Add SoundWire stream programming interface Date: Fri, 30 Mar 2018 08:03:25 +0200 Message-ID: <20180330060325.GA9729@kroah.com> References: <1522229918-4748-1-git-send-email-vinod.koul@intel.com> <1522229918-4748-9-git-send-email-vinod.koul@intel.com> <355ca9b5-d6c4-9423-8cf6-a1c73fbdc695@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by alsa0.perex.cz (Postfix) with ESMTP id 478922671B9 for ; Fri, 30 Mar 2018 08:03:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: <355ca9b5-d6c4-9423-8cf6-a1c73fbdc695@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: ALSA , Vinod Koul , Pierre-Louis Bossart , patches.audio@intel.com, liam.r.girdwood@linux.intel.com, tiwai@suse.de, broonie@kernel.org, Shreyas NC List-Id: alsa-devel@alsa-project.org On Fri, Mar 30, 2018 at 12:05:00PM +0900, Takashi Sakamoto wrote: > Hi, > > On Mar 28 2018 18:38, Vinod Koul wrote: > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > > index c0edac80df34..690e56a35237 100644 > > --- a/sound/soc/soc-core.c > > +++ b/sound/soc/soc-core.c > > @@ -2882,6 +2882,26 @@ int snd_soc_dai_set_tdm_slot(struct snd_soc_dai *dai, > > EXPORT_SYMBOL_GPL(snd_soc_dai_set_tdm_slot); > > /** > > + * snd_soc_dai_set_sdw_stream() - Configures a DAI for SDW stream operation > > + * @dai: DAI > > + * @stream: STREAM > > + * @direction: Stream direction(Playback/Capture) > > + * SoundWire subsystem doesn't have a notion of direction and we reuse > > + * the ASoC stream direction to configure sink/source ports. > > + * > > + * Returns 0 on success, a negative error code otherwise. > > + */ > > +int snd_soc_dai_set_sdw_stream(struct snd_soc_dai *dai, > > + void *stream, int direction) > > +{ > > + if (dai->driver->ops->set_sdw_stream) > > + return dai->driver->ops->set_sdw_stream(dai, stream, direction); > > + else > > + return -ENOTSUPP; > > +} > > +EXPORT_SYMBOL_GPL(snd_soc_dai_set_sdw_stream); > > It's better for this kind of code to be incline function in any header. In > general, new symbols increase maintenance cost of binary of kernel-related > stuffs. It's preferable to avoid the addition if possible, IMO. I don't understand, functionally it's the same, there should not be any increased maintenance either way. Please explain how this makes things "harder"? thanks, greg k-h