Re: [PATCH] drm/i915/execlists: Consistent seqno reporting in GEM_TRACE

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3722 bytes --]

Hi Tvrtko,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20180329]
[cannot apply to v4.16-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Tvrtko-Ursulin/drm-i915-execlists-Consistent-seqno-reporting-in-GEM_TRACE/20180330-120802
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x0-03302126 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/interrupt.h:6:0,
                    from drivers/gpu//drm/i915/intel_lrc.c:134:
   drivers/gpu//drm/i915/intel_lrc.c: In function 'execlists_cancel_port_requests':
>> drivers/gpu//drm/i915/intel_lrc.c:730:13: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Werror=format=]
      GEM_TRACE("%s:port%lu cancel %llx:%d [global %d]\n",
                ^
   include/linux/kernel.h:635:33: note: in definition of macro '__trace_printk_check_format'
      ____trace_printk_check_format(fmt, ##args);  \
                                    ^
   include/linux/kernel.h:672:3: note: in expansion of macro 'do_trace_printk'
      do_trace_printk(fmt, ##__VA_ARGS__); \
      ^
   drivers/gpu//drm/i915/i915_gem.h:55:24: note: in expansion of macro 'trace_printk'
    #define GEM_TRACE(...) trace_printk(__VA_ARGS__)
                           ^
   drivers/gpu//drm/i915/intel_lrc.c:730:3: note: in expansion of macro 'GEM_TRACE'
      GEM_TRACE("%s:port%lu cancel %llx:%d [global %d]\n",
      ^
   drivers/gpu//drm/i915/intel_lrc.c:730:13: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'int' [-Werror=format=]
      GEM_TRACE("%s:port%lu cancel %llx:%d [global %d]\n",
                ^
   include/linux/kernel.h:688:29: note: in definition of macro 'do_trace_printk'
      __trace_printk(_THIS_IP_, fmt, ##args);   \
                                ^
   drivers/gpu//drm/i915/i915_gem.h:55:24: note: in expansion of macro 'trace_printk'
    #define GEM_TRACE(...) trace_printk(__VA_ARGS__)
                           ^
   drivers/gpu//drm/i915/intel_lrc.c:730:3: note: in expansion of macro 'GEM_TRACE'
      GEM_TRACE("%s:port%lu cancel %llx:%d [global %d]\n",
      ^
   cc1: all warnings being treated as errors

vim +730 drivers/gpu//drm/i915/intel_lrc.c

   720	
   721	void
   722	execlists_cancel_port_requests(struct intel_engine_execlists * const execlists)
   723	{
   724		struct execlist_port *port = execlists->port;
   725		unsigned int num_ports = execlists_num_ports(execlists);
   726	
   727		while (num_ports-- && port_isset(port)) {
   728			struct i915_request *rq = port_request(port);
   729	
 > 730			GEM_TRACE("%s:port%lu cancel %llx:%d [global %d]\n",
   731				  rq->engine->name, port - execlists->port,
   732				  rq->fence.context, rq->fence.seqno, rq->global_seqno);
   733	
   734			GEM_BUG_ON(!execlists->active);
   735			intel_engine_context_out(rq->engine);
   736	
   737			execlists_context_status_change(rq,
   738							i915_request_completed(rq) ?
   739							INTEL_CONTEXT_SCHEDULE_OUT :
   740							INTEL_CONTEXT_SCHEDULE_PREEMPTED);
   741	
   742			i915_request_put(rq);
   743	
   744			memset(port, 0, sizeof(*port));
   745			port++;
   746		}
   747	}
   748	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30404 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx