From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 0/9] devlink: Add support for region access Date: Sat, 31 Mar 2018 17:53:45 +0200 Message-ID: <20180331155345.GA14758@lunn.ch> References: <1522339672-18273-1-git-send-email-valex@mellanox.com> <20180329171359.GA12150@lunn.ch> <962b56c1-d471-97ec-e8e9-18252e809dfe@mellanox.com> <20180329195154.GB15565@lunn.ch> <28b99a08-1967-3044-4010-0faa5d6bfc14@mellanox.com> <20180330143403.GD28244@lunn.ch> <6d55f271-18f9-9ca5-0dbf-24951dd09978@gmail.com> <98477af6-b774-48bd-f663-28a7f9f554e3@mellanox.com> <86ebf2c1-dcdf-bfad-f1b8-cf73acf08ddc@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Ahern , "David S. Miller" , netdev@vger.kernel.org, Tariq Toukan , Jiri Pirko To: Alex Vesker Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:48015 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358AbeCaPxv (ORCPT ); Sat, 31 Mar 2018 11:53:51 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > I want to be able to login to a customer and accessing this snapshot > without any previous configuration from the user and not asking for > enabling the feature and then waiting for a repro...this will help > debugging issues that are hard to reproduce, I don't see any reason > to disable this. The likely reality is 99.9% of these snapshots will never be seen or used. But they take up memory sitting there doing nothing. And if the snapshot is 2GB, that is a lot of memory. I expect a system admin wants to be able to choose to enable this feature or not, because of that memory. You should also consider implementing the memory pressure callbacks, so you can discard snapshots, rather than OOM the machine. Andrew