From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code Date: Mon, 02 Apr 2018 10:14:10 -0400 (EDT) Message-ID: <20180402.101410.2105582698262762699.davem@davemloft.net> References: <20180402074349.12010-1-akurz@blala.de> <20180402074349.12010-2-akurz@blala.de> <86woxqq6uz.wl-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: akurz@blala.de, afd@ti.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, freddy@asix.com.tw To: marc.zyngier@arm.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:37604 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbeDBOON (ORCPT ); Mon, 2 Apr 2018 10:14:13 -0400 In-Reply-To: <86woxqq6uz.wl-marc.zyngier@arm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Marc Zyngier Date: Mon, 02 Apr 2018 10:45:40 +0100 > What has changed between this patch and the previous one? Having a bit > of a change-log would certainly help. Also, I would have appreciated a > reply to the questions I had on v2 before you posted a third version. Agreed, and I'm not applying these patches until this is sorted out and explained properly. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,2/2] net: usb: asix88179_178a: de-duplicate code From: David Miller Message-Id: <20180402.101410.2105582698262762699.davem@davemloft.net> Date: Mon, 02 Apr 2018 10:14:10 -0400 (EDT) To: marc.zyngier@arm.com Cc: akurz@blala.de, afd@ti.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, freddy@asix.com.tw List-ID: RnJvbTogTWFyYyBaeW5naWVyIDxtYXJjLnp5bmdpZXJAYXJtLmNvbT4KRGF0ZTogTW9uLCAwMiBB cHIgMjAxOCAxMDo0NTo0MCArMDEwMAoKPiBXaGF0IGhhcyBjaGFuZ2VkIGJldHdlZW4gdGhpcyBw YXRjaCBhbmQgdGhlIHByZXZpb3VzIG9uZT8gSGF2aW5nIGEgYml0Cj4gb2YgYSBjaGFuZ2UtbG9n IHdvdWxkIGNlcnRhaW5seSBoZWxwLiBBbHNvLCBJIHdvdWxkIGhhdmUgYXBwcmVjaWF0ZWQgYQo+ IHJlcGx5IHRvIHRoZSBxdWVzdGlvbnMgSSBoYWQgb24gdjIgYmVmb3JlIHlvdSBwb3N0ZWQgYSB0 aGlyZCB2ZXJzaW9uLgoKQWdyZWVkLCBhbmQgSSdtIG5vdCBhcHBseWluZyB0aGVzZSBwYXRjaGVz IHVudGlsIHRoaXMgaXMgc29ydGVkIG91dAphbmQgZXhwbGFpbmVkIHByb3Blcmx5LgotLS0KVG8g dW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxp bnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5l bC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpv cmRvbW8taW5mby5odG1sCg==