From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Kurz Subject: [PATCH v3 1/2] net: usb: asix88179_178a: set permanent address once only Date: Mon, 2 Apr 2018 07:43:48 +0000 Message-ID: <20180402074349.12010-1-akurz@blala.de> Cc: "Andrew F . Davis" , Marc Zyngier , linux-usb@vger.kernel.org, netdev@vger.kernel.org, Freddy Xin , Alexander Kurz To: "David S . Miller" Return-path: Received: from vs10.datenmanufaktur-hosting.net ([185.138.26.202]:50706 "EHLO vs81.iboxed.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754218AbeDBHoM (ORCPT ); Mon, 2 Apr 2018 03:44:12 -0400 Sender: netdev-owner@vger.kernel.org List-ID: The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index f32261ecd215..a6ef75907ae9 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1556,7 +1556,6 @@ static int ax88179_reset(struct usbnet *dev) ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN, dev->net->dev_addr); - memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); /* RX bulk configuration */ memcpy(tmp, &AX88179_BULKIN_SIZE[0], 5); -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,1/2] net: usb: asix88179_178a: set permanent address once only From: Alexander Kurz Message-Id: <20180402074349.12010-1-akurz@blala.de> Date: Mon, 2 Apr 2018 07:43:48 +0000 To: "David S . Miller" Cc: "Andrew F . Davis" , Marc Zyngier , linux-usb@vger.kernel.org, netdev@vger.kernel.org, Freddy Xin , Alexander Kurz List-ID: VGhlIHBlcm1hbmVudCBhZGRyZXNzIG9mIGFzaXg4ODE3OV8xNzhhIGRldmljZXMgaXMgcmVhZCBh dCBwcm9iZSB0aW1lCmFuZCBzaG91bGQgbm90IGJlIG92ZXJ3cml0dGVuIGxhdGVyLiBPdGhlcndp c2UgaXQgbWF5IGJlIG92ZXJ3cml0dGVuCnVuaW50ZW50aW9uYWxseSB3aXRoIGEgY29uZmlndXJl ZCBhZGRyZXNzLgoKU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIEt1cnogPGFrdXJ6QGJsYWxhLmRl PgotLS0KIGRyaXZlcnMvbmV0L3VzYi9heDg4MTc5XzE3OGEuYyB8IDEgLQogMSBmaWxlIGNoYW5n ZWQsIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC91c2IvYXg4ODE3OV8x NzhhLmMgYi9kcml2ZXJzL25ldC91c2IvYXg4ODE3OV8xNzhhLmMKaW5kZXggZjMyMjYxZWNkMjE1 Li5hNmVmNzU5MDdhZTkgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbmV0L3VzYi9heDg4MTc5XzE3OGEu YworKysgYi9kcml2ZXJzL25ldC91c2IvYXg4ODE3OV8xNzhhLmMKQEAgLTE1NTYsNyArMTU1Niw2 IEBAIHN0YXRpYyBpbnQgYXg4ODE3OV9yZXNldChzdHJ1Y3QgdXNibmV0ICpkZXYpCiAKIAlheDg4 MTc5X3JlYWRfY21kKGRldiwgQVhfQUNDRVNTX01BQywgQVhfTk9ERV9JRCwgRVRIX0FMRU4sIEVU SF9BTEVOLAogCQkJIGRldi0+bmV0LT5kZXZfYWRkcik7Ci0JbWVtY3B5KGRldi0+bmV0LT5wZXJt X2FkZHIsIGRldi0+bmV0LT5kZXZfYWRkciwgRVRIX0FMRU4pOwogCiAJLyogUlggYnVsayBjb25m aWd1cmF0aW9uICovCiAJbWVtY3B5KHRtcCwgJkFYODgxNzlfQlVMS0lOX1NJWkVbMF0sIDUpOwo=