All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] log: Add units to code-size stats in README.log
@ 2018-04-02  8:42 Simon Glass
  2018-04-11 14:05 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Glass @ 2018-04-02  8:42 UTC (permalink / raw)
  To: u-boot

Without the units these numbers are confusing. Add a comment about the
unit being 'bytes' and mention 'buildman' as the source.

Suggested-by: Lukasz Majewski <lukma@denx.de>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

 doc/README.log | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/README.log b/doc/README.log
index dc9e2deec5..2ee1b753bc 100644
--- a/doc/README.log
+++ b/doc/README.log
@@ -162,7 +162,8 @@ Code size
 ---------
 
 Code size impact depends largely on what is enabled. The following numbers are
-for snow, which is a Thumb-2 board:
+generated by 'buildman -S' for snow, which is a Thumb-2 board (all units in
+bytes):
 
 This series: adds bss +20.0 data +4.0 rodata +4.0 text +44.0
 CONFIG_LOG: bss -52.0 data +92.0 rodata -635.0 text +1048.0
-- 
2.17.0.rc1.321.gba9d0f2565-goog

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] log: Add units to code-size stats in README.log
  2018-04-02  8:42 [U-Boot] [PATCH] log: Add units to code-size stats in README.log Simon Glass
@ 2018-04-11 14:05 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-04-11 14:05 UTC (permalink / raw)
  To: u-boot

On Mon, Apr 02, 2018 at 02:42:53AM -0600, Simon Glass wrote:

> Without the units these numbers are confusing. Add a comment about the
> unit being 'bytes' and mention 'buildman' as the source.
> 
> Suggested-by: Lukasz Majewski <lukma@denx.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180411/5abe5829/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-11 14:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-02  8:42 [U-Boot] [PATCH] log: Add units to code-size stats in README.log Simon Glass
2018-04-11 14:05 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.