From: Viresh Kumar <viresh.kumar@linaro.org> To: Ilia Lin <ilialin@codeaurora.org> Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, mark.rutland@arm.com, rjw@rjwysocki.net, lgirdwood@gmail.com, broonie@kernel.org, andy.gross@linaro.org, david.brown@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@codeaurora.org, amit.kucheria@linaro.org, nicolas.dechesne@linaro.org, celster@codeaurora.org, tfinkel@codeaurora.org Subject: Re: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996 Date: Mon, 2 Apr 2018 14:46:17 +0530 [thread overview] Message-ID: <20180402091617.GA3572@vireshk-i7> (raw) In-Reply-To: <1522358807-10413-9-git-send-email-ilialin@codeaurora.org> On 30-03-18, 00:26, Ilia Lin wrote: > Signed-off-by: Ilia Lin <ilialin@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 275 +++++++++++++++++++++++++++++++++- > 1 file changed, 267 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 410ae78..a0792bd 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -14,6 +14,7 @@ > #include <dt-bindings/clock/qcom,gcc-msm8996.h> > #include <dt-bindings/clock/qcom,mmcc-msm8996.h> > #include <dt-bindings/clock/qcom,rpmcc.h> > +#include <dt-bindings/thermal/thermal.h> > > / { > model = "Qualcomm Technologies, Inc. MSM8996"; > @@ -97,6 +98,11 @@ > compatible = "qcom,kryo"; > reg = <0x0 0x0>; > enable-method = "psci"; > + clocks = <&kryocc 0>; > + operating-points-v2 = <&cluster0_opp>; > + cooling-min-level = <0>; > + cooling-max-level = <15>; The min/max properties are removed from DT documentation now. You don't need to add them anymore. > + cluster0_opp: opp_table0 { > + compatible = "operating-points-v2"; > + opp-shared; Is Kryo like krait where CPUs do DVFS independently ? If yes, then opp-shared thing should be dropped. > + > + opp-307200000 { > + opp-hz = /bits/ 64 < 307200000 >; Why have you added spaces after < and before > here ? -- viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996 Date: Mon, 2 Apr 2018 14:46:17 +0530 [thread overview] Message-ID: <20180402091617.GA3572@vireshk-i7> (raw) In-Reply-To: <1522358807-10413-9-git-send-email-ilialin@codeaurora.org> On 30-03-18, 00:26, Ilia Lin wrote: > Signed-off-by: Ilia Lin <ilialin@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 275 +++++++++++++++++++++++++++++++++- > 1 file changed, 267 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 410ae78..a0792bd 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -14,6 +14,7 @@ > #include <dt-bindings/clock/qcom,gcc-msm8996.h> > #include <dt-bindings/clock/qcom,mmcc-msm8996.h> > #include <dt-bindings/clock/qcom,rpmcc.h> > +#include <dt-bindings/thermal/thermal.h> > > / { > model = "Qualcomm Technologies, Inc. MSM8996"; > @@ -97,6 +98,11 @@ > compatible = "qcom,kryo"; > reg = <0x0 0x0>; > enable-method = "psci"; > + clocks = <&kryocc 0>; > + operating-points-v2 = <&cluster0_opp>; > + cooling-min-level = <0>; > + cooling-max-level = <15>; The min/max properties are removed from DT documentation now. You don't need to add them anymore. > + cluster0_opp: opp_table0 { > + compatible = "operating-points-v2"; > + opp-shared; Is Kryo like krait where CPUs do DVFS independently ? If yes, then opp-shared thing should be dropped. > + > + opp-307200000 { > + opp-hz = /bits/ 64 < 307200000 >; Why have you added spaces after < and before > here ? -- viresh
next prev parent reply other threads:[~2018-04-02 9:16 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-29 21:26 [PATCH v4 00/14] CPU scaling support for msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 01/14] soc: qcom: Separate kryo l2 accessors from PMU driver Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-31 4:39 ` kbuild test robot 2018-03-31 4:39 ` kbuild test robot 2018-03-31 4:39 ` kbuild test robot 2018-04-01 22:34 ` Bjorn Andersson 2018-04-01 22:34 ` Bjorn Andersson 2018-03-29 21:26 ` [PATCH v4 02/14] clk: qcom: Make clk_alpha_pll_configure available to modules Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 03/14] clk: qcom: Add CPU clock driver for msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 04/14] clk: qcom: Add DT bindings for " Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-05 13:18 ` Rob Herring 2018-04-05 13:18 ` Rob Herring 2018-03-29 21:26 ` [PATCH v4 05/14] clk: qcom: cpu-8996: Add support to switch to alternate PLL Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 06/14] clk: qcom: cpu-8996: Add support to switch below 600Mhz Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 07/14] clk: qcom: Add ACD path to CPU clock driver for msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-02 9:16 ` Viresh Kumar [this message] 2018-04-02 9:16 ` Viresh Kumar 2018-05-04 6:04 ` Viresh Kumar 2018-05-04 6:04 ` Viresh Kumar 2018-05-04 6:04 ` Viresh Kumar 2018-05-04 6:48 ` ilialin 2018-05-04 6:48 ` ilialin at codeaurora.org 2018-05-04 6:48 ` ilialin 2018-05-04 6:48 ` ilialin 2018-05-04 7:03 ` Viresh Kumar 2018-05-04 7:03 ` Viresh Kumar 2018-05-04 7:03 ` Viresh Kumar 2018-03-29 21:26 ` [PATCH v4 09/14] regulator: qcom_spmi: Add support for SAW Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 10/14] dt-bindings: Add support for SAW documentation Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-09 20:21 ` Rob Herring 2018-04-09 20:21 ` Rob Herring 2018-04-17 11:09 ` Mark Brown 2018-04-17 11:09 ` Mark Brown 2018-03-29 21:26 ` [PATCH v4 11/14] dt: qcom: Add SAW regulator for 8x96 CPUs Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 12/14] cpufreq: Add Kryo CPU scaling driver Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-02 9:26 ` Viresh Kumar 2018-04-02 9:26 ` Viresh Kumar 2018-04-02 14:56 ` Sricharan R 2018-04-02 14:56 ` Sricharan R 2018-03-29 21:26 ` [PATCH v4 13/14] dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-02 9:30 ` Viresh Kumar 2018-04-02 9:30 ` Viresh Kumar 2018-04-02 15:07 ` Sricharan R 2018-04-02 15:07 ` Sricharan R 2018-04-03 2:41 ` Sricharan R 2018-04-03 2:41 ` Sricharan R 2018-04-03 4:23 ` Viresh Kumar 2018-04-03 4:23 ` Viresh Kumar 2018-04-03 16:39 ` Sricharan R 2018-04-03 16:39 ` Sricharan R 2018-03-29 21:26 ` [PATCH v4 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration Ilia Lin 2018-03-29 21:26 ` Ilia Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180402091617.GA3572@vireshk-i7 \ --to=viresh.kumar@linaro.org \ --cc=amit.kucheria@linaro.org \ --cc=andy.gross@linaro.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=celster@codeaurora.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=ilialin@codeaurora.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=nicolas.dechesne@linaro.org \ --cc=rjw@rjwysocki.net \ --cc=rnayak@codeaurora.org \ --cc=robh@kernel.org \ --cc=sboyd@kernel.org \ --cc=tfinkel@codeaurora.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.