From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [12/15] dmaengine: pxa: make the filter function internal From: Robert Jarzmik Message-Id: <20180402142656.26815-13-robert.jarzmik@free.fr> Date: Mon, 2 Apr 2018 16:26:53 +0200 To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Bartlomiej Zolnierkiewicz , Tejun Heo , Vinod Koul , Mauro Carvalho Chehab , Ulf Hansson , Ezequiel Garcia , Boris Brezillon , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Nicolas Pitre , Samuel Ortiz , Greg Kroah-Hartman , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Arnd Bergmann , Thomas Gleixner , Philippe Ombredanne , Kate Stewart Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, dmaengine@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org List-ID: QXMgdGhlIHB4YSBhcmNoaXRlY3R1cmUgYW5kIGFsbCBpdHMgcmVsYXRlZCBkcml2ZXJzIGRvIG5v dCByZWx5IGFueW1vcmUKb24gdGhlIGZpbHRlciBmdW5jdGlvbiwgdGhhbmtzIHRvIHRoZSBzbGF2 ZSBtYXAgY29udmVyc2lvbiwgbWFrZQpweGFkX2ZpbHRlcl9mbigpIHN0YXRpYywgYW5kIHJlbW92 ZSBpdCBmcm9tIHRoZSBnbG9iYWwgbmFtZXNwYWNlLgoKU2lnbmVkLW9mZi1ieTogUm9iZXJ0IEph cnptaWsgPHJvYmVydC5qYXJ6bWlrQGZyZWUuZnI+Ci0tLQogZHJpdmVycy9kbWEvcHhhX2RtYS5j ICAgICAgIHwgIDUgKystLS0KIGluY2x1ZGUvbGludXgvZG1hL3B4YS1kbWEuaCB8IDExIC0tLS0t LS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEvcHhhX2RtYS5jIGIvZHJpdmVycy9kbWEvcHhhX2Rt YS5jCmluZGV4IDk1MDUzMzRmOWM2ZS4uYTMzMmFkMWQ3ZGZiIDEwMDY0NAotLS0gYS9kcml2ZXJz L2RtYS9weGFfZG1hLmMKKysrIGIvZHJpdmVycy9kbWEvcHhhX2RtYS5jCkBAIC0xNzksNyArMTc5 LDcgQEAgc3RhdGljIHVuc2lnbmVkIGludCBweGFkX2RyY21yKHVuc2lnbmVkIGludCBsaW5lKQog CXJldHVybiAweDEwMDAgKyBsaW5lICogNDsKIH0KIAotYm9vbCBweGFkX2ZpbHRlcl9mbihzdHJ1 Y3QgZG1hX2NoYW4gKmNoYW4sIHZvaWQgKnBhcmFtKTsKK3N0YXRpYyBib29sIHB4YWRfZmlsdGVy X2ZuKHN0cnVjdCBkbWFfY2hhbiAqY2hhbiwgdm9pZCAqcGFyYW0pOwogCiAvKgogICogRGVidWcg ZnMKQEAgLTE0OTYsNyArMTQ5Niw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHB4 YWRfZHJpdmVyID0gewogCS5yZW1vdmUJCT0gcHhhZF9yZW1vdmUsCiB9OwogCi1ib29sIHB4YWRf ZmlsdGVyX2ZuKHN0cnVjdCBkbWFfY2hhbiAqY2hhbiwgdm9pZCAqcGFyYW0pCitzdGF0aWMgYm9v bCBweGFkX2ZpbHRlcl9mbihzdHJ1Y3QgZG1hX2NoYW4gKmNoYW4sIHZvaWQgKnBhcmFtKQogewog CXN0cnVjdCBweGFkX2NoYW4gKmMgPSB0b19weGFkX2NoYW4oY2hhbik7CiAJc3RydWN0IHB4YWRf cGFyYW0gKnAgPSBwYXJhbTsKQEAgLTE1MDksNyArMTUwOSw2IEBAIGJvb2wgcHhhZF9maWx0ZXJf Zm4oc3RydWN0IGRtYV9jaGFuICpjaGFuLCB2b2lkICpwYXJhbSkKIAogCXJldHVybiB0cnVlOwog fQotRVhQT1JUX1NZTUJPTF9HUEwocHhhZF9maWx0ZXJfZm4pOwogCiBtb2R1bGVfcGxhdGZvcm1f ZHJpdmVyKHB4YWRfZHJpdmVyKTsKIApkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9kbWEvcHhh LWRtYS5oIGIvaW5jbHVkZS9saW51eC9kbWEvcHhhLWRtYS5oCmluZGV4IDlmYzU5NGY2OWVmZi4u ZmNlYjVkZjA3MDk3IDEwMDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4L2RtYS9weGEtZG1hLmgKKysr IGIvaW5jbHVkZS9saW51eC9kbWEvcHhhLWRtYS5oCkBAIC0yMywxNSArMjMsNCBAQCBzdHJ1Y3Qg cHhhZF9wYXJhbSB7CiAJZW51bSBweGFkX2NoYW5fcHJpbyBwcmlvOwogfTsKIAotc3RydWN0IGRt YV9jaGFuOwotCi0jaWZkZWYgQ09ORklHX1BYQV9ETUEKLWJvb2wgcHhhZF9maWx0ZXJfZm4oc3Ry dWN0IGRtYV9jaGFuICpjaGFuLCB2b2lkICpwYXJhbSk7Ci0jZWxzZQotc3RhdGljIGlubGluZSBi b29sIHB4YWRfZmlsdGVyX2ZuKHN0cnVjdCBkbWFfY2hhbiAqY2hhbiwgdm9pZCAqcGFyYW0pCi17 Ci0JcmV0dXJuIGZhbHNlOwotfQotI2VuZGlmCi0KICNlbmRpZiAvKiBfUFhBX0RNQV9IXyAqLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: [PATCH 12/15] dmaengine: pxa: make the filter function internal Date: Mon, 2 Apr 2018 16:26:53 +0200 Message-ID: <20180402142656.26815-13-robert.jarzmik@free.fr> References: <20180402142656.26815-1-robert.jarzmik@free.fr> Return-path: In-Reply-To: <20180402142656.26815-1-robert.jarzmik@free.fr> Sender: netdev-owner@vger.kernel.org To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Bartlomiej Zolnierkiewicz , Tejun Heo , Vinod Koul , Mauro Carvalho Chehab , Ulf Hansson , Ezequiel Garcia , Boris Brezillon , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Nicolas Pitre , Samuel Ortiz , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, dmaengine@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org List-Id: linux-ide@vger.kernel.org As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma/pxa-dma.h | 11 ----------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 9505334f9c6e..a332ad1d7dfb 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -179,7 +179,7 @@ static unsigned int pxad_drcmr(unsigned int line) return 0x1000 + line * 4; } -bool pxad_filter_fn(struct dma_chan *chan, void *param); +static bool pxad_filter_fn(struct dma_chan *chan, void *param); /* * Debug fs @@ -1496,7 +1496,7 @@ static struct platform_driver pxad_driver = { .remove = pxad_remove, }; -bool pxad_filter_fn(struct dma_chan *chan, void *param) +static bool pxad_filter_fn(struct dma_chan *chan, void *param) { struct pxad_chan *c = to_pxad_chan(chan); struct pxad_param *p = param; @@ -1509,7 +1509,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param) return true; } -EXPORT_SYMBOL_GPL(pxad_filter_fn); module_platform_driver(pxad_driver); diff --git a/include/linux/dma/pxa-dma.h b/include/linux/dma/pxa-dma.h index 9fc594f69eff..fceb5df07097 100644 --- a/include/linux/dma/pxa-dma.h +++ b/include/linux/dma/pxa-dma.h @@ -23,15 +23,4 @@ struct pxad_param { enum pxad_chan_prio prio; }; -struct dma_chan; - -#ifdef CONFIG_PXA_DMA -bool pxad_filter_fn(struct dma_chan *chan, void *param); -#else -static inline bool pxad_filter_fn(struct dma_chan *chan, void *param) -{ - return false; -} -#endif - #endif /* _PXA_DMA_H_ */ -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4/p9M4nZU/53mvGumssI9jiXJp3h3dTXQo3R+OYrpkoh9nDKqxIzMmkGtCoRa3e2NOx7DQM ARC-Seal: i=1; a=rsa-sha256; t=1522679308; cv=none; d=google.com; s=arc-20160816; b=naPYlVxS89I8yW/aAkPm4j0daM4f0ROafQpdL9CjB0ZciUI9iVqE/TCqaTwYvZ/Bnd +vqtKDKfqoNJjxGYXhWgEg4AuC7/1iT/cViWbBIKsU8nwYpzXxSGJumWTmeHlFkewgns PWGa6yQEnyjFgJXaJDxxRImgF3hs4DyaS6qvteW87z48OOcOnlv5M4HWBncXAUmlB1if cEZ5FEsmfyreNs6sY5271r1or1ojydv7iI59mvMosPaNPGHO2D4JzCkjB0UcirZD2aM/ YFNah49iibs92euAEXeglYN3wlui/k5Q7FMkQiDaNdOwusKEkMKaxKpA0XF0rhTOoNFh wPxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=5C8d3XEVPJw3oAhSe02klOFH8TjrqrBV3cvYNbztPXM=; b=lNRYxJ1c8p30ORNDnyI6nFdsGIxPY78IdRksmXPYsqOO30oGL/I4htnnXwDBDWNKE9 UH9nlCQZjWO+0k29rTAnWUGKeQqTo6mpgqPt7oFudwHJ0HOeFh5QdaCBcxjZufRuo6rJ xMKyw3UyWPWBDsAGSeJd0Myh04pjNLk+qMQPDRI+zooBwPtuHkwCJ7XEzqBZJK0+k8/Y Ba69aMVU3au15/CSTjC/QZI+cUlz4F97Lgu4Fc6fPtVgtMOHW1UHWrBGTFGD3QKMwLJ6 p7DJSeY2berg/yuiB+k2zgI1E2RBGMJinjmOA+9TAUduETbfPnAHEjsXvDVYS9yCpUME OShQ== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 80.12.242.128 is neither permitted nor denied by best guess record for domain of robert.jarzmik@free.fr) smtp.mailfrom=robert.jarzmik@free.fr Authentication-Results: mx.google.com; spf=neutral (google.com: 80.12.242.128 is neither permitted nor denied by best guess record for domain of robert.jarzmik@free.fr) smtp.mailfrom=robert.jarzmik@free.fr X-ME-Helo: belgarion.home X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 02 Apr 2018 16:28:27 +0200 X-ME-IP: 86.201.130.131 From: Robert Jarzmik To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Bartlomiej Zolnierkiewicz , Tejun Heo , Vinod Koul , Mauro Carvalho Chehab , Ulf Hansson , Ezequiel Garcia , Boris Brezillon , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Nicolas Pitre , Samuel Ortiz , Greg Kroah-Hartman , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Arnd Bergmann , Thomas Gleixner , Philippe Ombredanne , Kate Stewart Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, dmaengine@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org Subject: [PATCH 12/15] dmaengine: pxa: make the filter function internal Date: Mon, 2 Apr 2018 16:26:53 +0200 Message-Id: <20180402142656.26815-13-robert.jarzmik@free.fr> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180402142656.26815-1-robert.jarzmik@free.fr> References: <20180402142656.26815-1-robert.jarzmik@free.fr> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1596644978542535550?= X-GMAIL-MSGID: =?utf-8?q?1596644978542535550?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma/pxa-dma.h | 11 ----------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 9505334f9c6e..a332ad1d7dfb 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -179,7 +179,7 @@ static unsigned int pxad_drcmr(unsigned int line) return 0x1000 + line * 4; } -bool pxad_filter_fn(struct dma_chan *chan, void *param); +static bool pxad_filter_fn(struct dma_chan *chan, void *param); /* * Debug fs @@ -1496,7 +1496,7 @@ static struct platform_driver pxad_driver = { .remove = pxad_remove, }; -bool pxad_filter_fn(struct dma_chan *chan, void *param) +static bool pxad_filter_fn(struct dma_chan *chan, void *param) { struct pxad_chan *c = to_pxad_chan(chan); struct pxad_param *p = param; @@ -1509,7 +1509,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param) return true; } -EXPORT_SYMBOL_GPL(pxad_filter_fn); module_platform_driver(pxad_driver); diff --git a/include/linux/dma/pxa-dma.h b/include/linux/dma/pxa-dma.h index 9fc594f69eff..fceb5df07097 100644 --- a/include/linux/dma/pxa-dma.h +++ b/include/linux/dma/pxa-dma.h @@ -23,15 +23,4 @@ struct pxad_param { enum pxad_chan_prio prio; }; -struct dma_chan; - -#ifdef CONFIG_PXA_DMA -bool pxad_filter_fn(struct dma_chan *chan, void *param); -#else -static inline bool pxad_filter_fn(struct dma_chan *chan, void *param) -{ - return false; -} -#endif - #endif /* _PXA_DMA_H_ */ -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: [PATCH 12/15] dmaengine: pxa: make the filter function internal Date: Mon, 2 Apr 2018 16:26:53 +0200 Message-ID: <20180402142656.26815-13-robert.jarzmik@free.fr> References: <20180402142656.26815-1-robert.jarzmik@free.fr> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, dmaengine@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Bartlomiej Zolnierkiewicz , Tejun Heo , Vinod Koul , Mauro Carvalho Chehab , Ulf Hansson , Ezequiel Garcia , Boris Brezillon , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Nicolas Pitre , Samuel Ortiz , Greg Kroah-Hartman , Jaroslav Kysela < Return-path: Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:53784 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbeDBO23 (ORCPT ); Mon, 2 Apr 2018 10:28:29 -0400 In-Reply-To: <20180402142656.26815-1-robert.jarzmik@free.fr> Sender: netdev-owner@vger.kernel.org List-ID: As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma/pxa-dma.h | 11 ----------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 9505334f9c6e..a332ad1d7dfb 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -179,7 +179,7 @@ static unsigned int pxad_drcmr(unsigned int line) return 0x1000 + line * 4; } -bool pxad_filter_fn(struct dma_chan *chan, void *param); +static bool pxad_filter_fn(struct dma_chan *chan, void *param); /* * Debug fs @@ -1496,7 +1496,7 @@ static struct platform_driver pxad_driver = { .remove = pxad_remove, }; -bool pxad_filter_fn(struct dma_chan *chan, void *param) +static bool pxad_filter_fn(struct dma_chan *chan, void *param) { struct pxad_chan *c = to_pxad_chan(chan); struct pxad_param *p = param; @@ -1509,7 +1509,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param) return true; } -EXPORT_SYMBOL_GPL(pxad_filter_fn); module_platform_driver(pxad_driver); diff --git a/include/linux/dma/pxa-dma.h b/include/linux/dma/pxa-dma.h index 9fc594f69eff..fceb5df07097 100644 --- a/include/linux/dma/pxa-dma.h +++ b/include/linux/dma/pxa-dma.h @@ -23,15 +23,4 @@ struct pxad_param { enum pxad_chan_prio prio; }; -struct dma_chan; - -#ifdef CONFIG_PXA_DMA -bool pxad_filter_fn(struct dma_chan *chan, void *param); -#else -static inline bool pxad_filter_fn(struct dma_chan *chan, void *param) -{ - return false; -} -#endif - #endif /* _PXA_DMA_H_ */ -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Mon, 2 Apr 2018 16:26:53 +0200 Subject: [PATCH 12/15] dmaengine: pxa: make the filter function internal In-Reply-To: <20180402142656.26815-1-robert.jarzmik@free.fr> References: <20180402142656.26815-1-robert.jarzmik@free.fr> Message-ID: <20180402142656.26815-13-robert.jarzmik@free.fr> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma/pxa-dma.h | 11 ----------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 9505334f9c6e..a332ad1d7dfb 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -179,7 +179,7 @@ static unsigned int pxad_drcmr(unsigned int line) return 0x1000 + line * 4; } -bool pxad_filter_fn(struct dma_chan *chan, void *param); +static bool pxad_filter_fn(struct dma_chan *chan, void *param); /* * Debug fs @@ -1496,7 +1496,7 @@ static struct platform_driver pxad_driver = { .remove = pxad_remove, }; -bool pxad_filter_fn(struct dma_chan *chan, void *param) +static bool pxad_filter_fn(struct dma_chan *chan, void *param) { struct pxad_chan *c = to_pxad_chan(chan); struct pxad_param *p = param; @@ -1509,7 +1509,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param) return true; } -EXPORT_SYMBOL_GPL(pxad_filter_fn); module_platform_driver(pxad_driver); diff --git a/include/linux/dma/pxa-dma.h b/include/linux/dma/pxa-dma.h index 9fc594f69eff..fceb5df07097 100644 --- a/include/linux/dma/pxa-dma.h +++ b/include/linux/dma/pxa-dma.h @@ -23,15 +23,4 @@ struct pxad_param { enum pxad_chan_prio prio; }; -struct dma_chan; - -#ifdef CONFIG_PXA_DMA -bool pxad_filter_fn(struct dma_chan *chan, void *param); -#else -static inline bool pxad_filter_fn(struct dma_chan *chan, void *param) -{ - return false; -} -#endif - #endif /* _PXA_DMA_H_ */ -- 2.11.0