From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754915AbeDCJrj (ORCPT ); Tue, 3 Apr 2018 05:47:39 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37286 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754579AbeDCJri (ORCPT ); Tue, 3 Apr 2018 05:47:38 -0400 X-Google-Smtp-Source: AIpwx4/yq8cD0nCrruG9R8k6F/gkK3ZM06xa10EWbPssKzUa5RX6E/UYGsCBdABiiwxJWapiAUOSeA== Date: Tue, 3 Apr 2018 11:47:34 +0200 From: Daniel Vetter To: Oleksandr Andrushchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, gustavo@padovan.org, jgross@suse.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, Oleksandr Andrushchenko Subject: Re: [PATCH 1/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver Message-ID: <20180403094734.GT3881@phenom.ffwll.local> Mail-Followup-To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, gustavo@padovan.org, jgross@suse.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, Oleksandr Andrushchenko References: <20180329131931.29957-1-andr2000@gmail.com> <20180329131931.29957-2-andr2000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180329131931.29957-2-andr2000@gmail.com> X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 29, 2018 at 04:19:31PM +0300, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > +static int to_refs_grant_foreign_access(struct xen_gem_object *xen_obj) > +{ > + grant_ref_t priv_gref_head; > + int ret, j, cur_ref, num_pages; > + struct sg_page_iter sg_iter; > + > + ret = gnttab_alloc_grant_references(xen_obj->num_pages, > + &priv_gref_head); > + if (ret < 0) { > + DRM_ERROR("Cannot allocate grant references\n"); > + return ret; > + } > + > + j = 0; > + num_pages = xen_obj->num_pages; > + for_each_sg_page(xen_obj->sgt->sgl, &sg_iter, xen_obj->sgt->nents, 0) { > + struct page *page; > + > + page = sg_page_iter_page(&sg_iter); Quick drive-by: You can't assume that an sgt is struct page backed. And you probably want to check this at import/attach time. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver Date: Tue, 3 Apr 2018 11:47:34 +0200 Message-ID: <20180403094734.GT3881@phenom.ffwll.local> References: <20180329131931.29957-1-andr2000@gmail.com> <20180329131931.29957-2-andr2000@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3502789A4B for ; Tue, 3 Apr 2018 09:47:38 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id x82so33730152wmg.1 for ; Tue, 03 Apr 2018 02:47:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180329131931.29957-2-andr2000@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oleksandr Andrushchenko Cc: jgross@suse.com, konrad.wilk@oracle.com, airlied@linux.ie, Oleksandr Andrushchenko , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMjksIDIwMTggYXQgMDQ6MTk6MzFQTSArMDMwMCwgT2xla3NhbmRyIEFuZHJ1 c2hjaGVua28gd3JvdGU6Cj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5k cl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPgo+ICtzdGF0aWMgaW50IHRvX3JlZnNfZ3JhbnRfZm9y ZWlnbl9hY2Nlc3Moc3RydWN0IHhlbl9nZW1fb2JqZWN0ICp4ZW5fb2JqKQo+ICt7Cj4gKwlncmFu dF9yZWZfdCBwcml2X2dyZWZfaGVhZDsKPiArCWludCByZXQsIGosIGN1cl9yZWYsIG51bV9wYWdl czsKPiArCXN0cnVjdCBzZ19wYWdlX2l0ZXIgc2dfaXRlcjsKPiArCj4gKwlyZXQgPSBnbnR0YWJf YWxsb2NfZ3JhbnRfcmVmZXJlbmNlcyh4ZW5fb2JqLT5udW1fcGFnZXMsCj4gKwkJCSZwcml2X2dy ZWZfaGVhZCk7Cj4gKwlpZiAocmV0IDwgMCkgewo+ICsJCURSTV9FUlJPUigiQ2Fubm90IGFsbG9j YXRlIGdyYW50IHJlZmVyZW5jZXNcbiIpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJ aiA9IDA7Cj4gKwludW1fcGFnZXMgPSB4ZW5fb2JqLT5udW1fcGFnZXM7Cj4gKwlmb3JfZWFjaF9z Z19wYWdlKHhlbl9vYmotPnNndC0+c2dsLCAmc2dfaXRlciwgeGVuX29iai0+c2d0LT5uZW50cywg MCkgewo+ICsJCXN0cnVjdCBwYWdlICpwYWdlOwo+ICsKPiArCQlwYWdlID0gc2dfcGFnZV9pdGVy X3BhZ2UoJnNnX2l0ZXIpOwoKUXVpY2sgZHJpdmUtYnk6IFlvdSBjYW4ndCBhc3N1bWUgdGhhdCBh biBzZ3QgaXMgc3RydWN0IHBhZ2UgYmFja2VkLgoKQW5kIHlvdSBwcm9iYWJseSB3YW50IHRvIGNo ZWNrIHRoaXMgYXQgaW1wb3J0L2F0dGFjaCB0aW1lLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVy ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK