From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v9 5/9] eventtimer: add default software
	driver
Date: Tue, 3 Apr 2018 15:29:50 +0530
Message-ID: <20180403095949.GC8038@ltp-pvn>
References: <1522358852-3630-1-git-send-email-erik.g.carrillo@intel.com>
 <1522697994-22515-1-git-send-email-erik.g.carrillo@intel.com>
 <1522697994-22515-6-git-send-email-erik.g.carrillo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
 jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0060.outbound.protection.outlook.com [104.47.34.60])
 by dpdk.org (Postfix) with ESMTP id E0D151B6D5
 for <dev@dpdk.org>; Tue,  3 Apr 2018 12:00:12 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1522697994-22515-6-git-send-email-erik.g.carrillo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Erik,

On Mon, Apr 02, 2018 at 02:39:50PM -0500, Erik Gabriel Carrillo wrote:
> If an eventdev PMD does not wish to provide event timer adapter ops
> definitions, the library will fall back to a default software
> implementation whose entry points are added by this commit.
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
>  lib/Makefile                                  |   2 +-
>  lib/librte_eventdev/Makefile                  |   2 +-
>  lib/librte_eventdev/rte_event_timer_adapter.c | 909 ++++++++++++++++++++++++++
>  lib/librte_eventdev/rte_event_timer_adapter.h |  57 +-
>  4 files changed, 966 insertions(+), 4 deletions(-)
>
<snip>
> +const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops;

We can make this as static instead of global as it is only used in this file.

> +
>  #define EVTIM_LOG(level, logtype, ...) \
>  	rte_log(RTE_LOG_ ## level, logtype, \
>  		RTE_FMT("EVTIMER: %s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) \
> @@ -33,8 +46,14 @@ static struct rte_event_timer_adapter adapters[RTE_EVENT_TIMER_ADAPTER_NUM_MAX];
>  #ifdef RTE_LIBRTE_EVENTDEV_DEBUG
>  #define EVTIM_LOG_DBG(...) \
>  	EVTIM_LOG(DEBUG, evtim_logtype, __VA_ARGS__)
> +#define EVTIM_BUF_LOG_DBG(...) \
> +	EVTIM_LOG(DEBUG, evtim_buffer_logtype, __VA_ARGS__)
> +#define EVTIM_SVC_LOG_DBG(...) \
> +	EVTIM_LOG(DEBUG, evtim_svc_logtype, __VA_ARGS__)
>  #else
>  #define EVTIM_LOG_DBG(...) (void)0
> +#define EVTIM_BUF_LOG_DBG(...) (void)0
> +#define EVTIM_SVC_LOG_DBG(...) (void)0
>  #endif

<snip>
> +
> +const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops = {
> +	.init = sw_event_timer_adapter_init,
> +	.uninit = sw_event_timer_adapter_uninit,
> +	.start = sw_event_timer_adapter_start,
> +	.stop = sw_event_timer_adapter_stop,
> +	.get_info = sw_event_timer_adapter_get_info,
> +	.stats_get = sw_event_timer_adapter_stats_get,
> +	.stats_reset = sw_event_timer_adapter_stats_reset,
> +	.arm_burst = sw_event_timer_arm_burst,
> +	.arm_tmo_tick_burst = sw_event_timer_arm_tmo_tick_burst,
> +	.cancel_burst = sw_event_timer_cancel_burst,
> +};

Move this above and make it static.

> +

With the above changes
Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>