All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <natechancellor@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org
Subject: Re: Clang warning fixes for 4.4 and 4.9
Date: Tue, 3 Apr 2018 05:46:34 -0700	[thread overview]
Message-ID: <20180403124634.GB13077@flashbox> (raw)
In-Reply-To: <20180403102826.GC17259@kroah.com>

On Tue, Apr 03, 2018 at 12:28:26PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 01, 2018 at 03:44:46AM -0700, Nathan Chancellor wrote:
> > db0a6fb5d97a ("audit: add tty field to LOGIN event")
> 
> This feels like a new feature, not a clang build warning fix, right?
> Why is it needed?
> 
> thanks,
> 
> greg k-h

It very well might but it does fix the following Clang warning:

../kernel/audit.c:1894:59: warning: address of array
'tsk->signal->tty->name' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (tsk->signal && tsk->signal->tty && tsk->signal->tty->name)
                                            ~~ ~~~~~~~~~~~~~~~~~~^~~~
1 warning generated.

I guess a 4.4 only fix would be to remove the '&& tsk->signal->tty->name'
but I know you have said many times that just taking the patch in
Linus' tree is preferred.

Thanks!
Nathan

  reply	other threads:[~2018-04-03 12:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-01 10:44 Clang warning fixes for 4.4 and 4.9 Nathan Chancellor
2018-04-03 10:28 ` Greg Kroah-Hartman
2018-04-03 12:46   ` Nathan Chancellor [this message]
2018-04-03 15:08     ` Greg Kroah-Hartman
2018-04-03 13:09 ` Greg Kroah-Hartman
2018-04-03 13:21   ` Nathan Chancellor
2018-04-03 13:33     ` Greg Kroah-Hartman
2018-04-03 15:08 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180403124634.GB13077@flashbox \
    --to=natechancellor@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.