Hi Niklas,

Thanks for your review,

On Thu, Mar 29, 2018 at 03:32:55PM +0200, Niklas Söderlund wrote:
> > diff --git a/drivers/media/platform/cadence/Kconfig b/drivers/media/platform/cadence/Kconfig
> > new file mode 100644
> > index 000000000000..18f061e5cbd1
> > --- /dev/null
> > +++ b/drivers/media/platform/cadence/Kconfig
> > @@ -0,0 +1,17 @@
> > +config VIDEO_CADENCE
> > +	bool "Cadence Video Devices"
> 
> I'm no expert on Kconfig best practices so if nothing else I might learn 
> something. There is no need to add a description to this option as it 
> only groups the Cadence drivers?

You don't strictly need it, but you're right and one should be better,
I've added it.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com