From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751270AbeDDGxE (ORCPT ); Wed, 4 Apr 2018 02:53:04 -0400 Received: from mail.bootlin.com ([62.4.15.54]:37852 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbeDDGxD (ORCPT ); Wed, 4 Apr 2018 02:53:03 -0400 Date: Wed, 4 Apr 2018 08:53:02 +0200 From: Maxime Ripard To: Sergey Suloev Cc: Mark Brown , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] spi: sun6i: use completion provided by SPI core Message-ID: <20180404065302.kq5uuybi4n4s3syr@flea> References: <20180403154449.2443-1-ssuloev@orpaltech.com> <20180403154449.2443-5-ssuloev@orpaltech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4mcen6okihu6dx5e" Content-Disposition: inline In-Reply-To: <20180403154449.2443-5-ssuloev@orpaltech.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4mcen6okihu6dx5e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 03, 2018 at 06:44:47PM +0300, Sergey Suloev wrote: > As long as the completion is already provided by the SPI core > then there is no need to waste extra-memory on this. > Also a waiting function was added to avoid code duplication. This would need to be split in two patches, one to add the waiting function, the other one to convert to the core struct completion Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --4mcen6okihu6dx5e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlrEdk0ACgkQ0rTAlCFN r3QRbA//WwutpY6L4PvCzTsynlQcfw2t+pguHr3e+iqcmvOf8hDJlwosdqH9dyEk 2TZRp9EL6wNHdIHF7lWDT66eyGKR1oDItwJqS7mbhZhNaFMVop8V3zvy1GHNNDDI v80zjqCJnj6Fli3+8aKO53sWqpoCPbrM27kOyj5O3ozM1jeLvsZNlF5mJLxmSy6E uGHTWjp00Fwox/qf4R73IF8AwRXtJjHjr+B5FVFl5gkkxCep2QbEdcOPIN/DTeqa yLNCuZfV7INok/lMlhuSDAo0TjBFvtX8OCGWPQKFVjhbFc8xDmEyMmERIuO4BGDn KAeo8YJmVb9LuHmLgCM2JWP2jo/Ej3/uyOLywiLk3Y0h+Bi0lgewDjiO7Wp7D+Wu dP3WQ+WD8/2nvHWy+5q/wBrCLaj27PxFN4kepKKlczEVJHEhmFvM4/hE8a8XADkJ e/bxwhOty+cflJFqbMmbvj9WgFjVJHF+RVpi4FjCSCVxz8TqPhjO8iK9XlnSGYVc z+wuE9eKyzYcHG7qCd6FtqkcXrFRKU9uWAdKl1jbid89NzpvGPspfgml2EqRjOuJ vTjqxIeqmZQZvCJGFDnVrjvCqkAVDmBtcVkIj47IaHeYPT/Layt3lKLLGNZRJc0v nw1YyTLgVB8a9wCDiD+OtMnYwYRhM7eNl5OGfUoU8lZXR1FnIfA= =pphr -----END PGP SIGNATURE----- --4mcen6okihu6dx5e-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Wed, 4 Apr 2018 08:53:02 +0200 Subject: [PATCH v3 4/6] spi: sun6i: use completion provided by SPI core In-Reply-To: <20180403154449.2443-5-ssuloev@orpaltech.com> References: <20180403154449.2443-1-ssuloev@orpaltech.com> <20180403154449.2443-5-ssuloev@orpaltech.com> Message-ID: <20180404065302.kq5uuybi4n4s3syr@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 03, 2018 at 06:44:47PM +0300, Sergey Suloev wrote: > As long as the completion is already provided by the SPI core > then there is no need to waste extra-memory on this. > Also a waiting function was added to avoid code duplication. This would need to be split in two patches, one to add the waiting function, the other one to convert to the core struct completion Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: