All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	"Tobin C . Harding" <me@tobin.cc>, Joe Perches <joe@perches.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>
Subject: [PATCH v4 6/9] vsprintf: Factor out %pV handler as va_format()
Date: Wed,  4 Apr 2018 10:58:40 +0200	[thread overview]
Message-ID: <20180404085843.16050-7-pmladek@suse.com> (raw)
In-Reply-To: <20180404085843.16050-1-pmladek@suse.com>

Move the code from the long pointer() function. We are going to add a check
for the access to the address that will make it even more complicated.

This patch does not change the existing behavior.

Signed-off-by: Petr Mladek <pmladek@suse.com>
---
 lib/vsprintf.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 88b80c7059f0..f20eaa3f0092 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1410,6 +1410,19 @@ char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec,
 }
 
 static noinline_for_stack
+char *va_format(char *buf, char *end, struct va_format *va_fmt)
+{
+	va_list va;
+
+	va_copy(va, *va_fmt->va);
+	buf += vsnprintf(buf, end > buf ? end - buf : 0,
+			 va_fmt->fmt, va);
+	va_end(va);
+
+	return buf;
+}
+
+static noinline_for_stack
 char *uuid_string(char *buf, char *end, const u8 *addr,
 		  struct printf_spec spec, const char *fmt)
 {
@@ -1946,15 +1959,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
 	case 'U':
 		return uuid_string(buf, end, ptr, spec, fmt);
 	case 'V':
-		{
-			va_list va;
-
-			va_copy(va, *((struct va_format *)ptr)->va);
-			buf += vsnprintf(buf, end > buf ? end - buf : 0,
-					 ((struct va_format *)ptr)->fmt, va);
-			va_end(va);
-			return buf;
-		}
+		return va_format(buf, end, ptr);
 	case 'K':
 		return restricted_pointer(buf, end, ptr, spec);
 	case 'N':
-- 
2.13.6

  parent reply	other threads:[~2018-04-04  9:00 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  8:58 [PATCH v4 0/9] vsprintf: Prevent silent crashes and consolidate error handling Petr Mladek
2018-04-04  8:58 ` [PATCH v4 1/9] vsprintf: Shuffle ptr_to_id() code Petr Mladek
2018-04-04  8:58 ` [PATCH v4 2/9] vsprintf: Consistent %pK handling for kptr_restrict == 0 Petr Mladek
2018-04-04 23:10   ` Sergey Senozhatsky
2018-04-05 14:34     ` Petr Mladek
2018-04-05 13:04   ` Andy Shevchenko
2018-04-05 14:46     ` Petr Mladek
2018-04-07 14:08       ` Andy Shevchenko
2018-04-09 12:05         ` Petr Mladek
2018-04-09 12:11           ` Andy Shevchenko
2018-04-04  8:58 ` [PATCH v4 3/9] vsprintf: Do not check address of well-known strings Petr Mladek
2018-04-05 13:30   ` Rasmus Villemoes
2018-04-06  9:15     ` Petr Mladek
2018-04-07 14:12       ` Andy Shevchenko
2018-04-09 12:19         ` Petr Mladek
2018-04-10 10:05           ` Andy Shevchenko
2018-04-04  8:58 ` [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers Petr Mladek
2018-04-05 14:25   ` Rasmus Villemoes
2018-04-05 23:45     ` Joe Perches
2018-04-05 23:55       ` Joe Perches
2018-04-06 11:43         ` Petr Mladek
2018-04-06 13:17           ` Rasmus Villemoes
2018-04-06 14:27             ` Joe Perches
2018-04-09 12:30               ` Petr Mladek
2018-04-07 14:23             ` Andy Shevchenko
2018-04-06 23:52         ` Sergey Senozhatsky
2018-04-06 23:59           ` Joe Perches
2018-04-07  0:33             ` Sergey Senozhatsky
2018-04-07  1:00               ` Joe Perches
2018-04-07  1:17                 ` Sergey Senozhatsky
2018-04-06 11:25     ` Petr Mladek
2018-04-07 14:26   ` Andy Shevchenko
2018-04-09 13:50     ` Petr Mladek
2018-04-10 11:41       ` Andy Shevchenko
2018-04-11  9:52         ` Petr Mladek
2018-04-24 16:47           ` Andy Shevchenko
2018-04-04  8:58 ` [PATCH v4 5/9] vsprintf: Factor out %p[iI] handler as ip_addr_string() Petr Mladek
2018-04-04 23:58   ` Sergey Senozhatsky
2018-04-05 14:14     ` Petr Mladek
2018-04-07 14:30   ` Andy Shevchenko
2018-04-04  8:58 ` Petr Mladek [this message]
2018-04-04 14:26   ` [PATCH v4 6/9] vsprintf: Factor out %pV handler as va_format() Joe Perches
2018-04-06 13:12     ` Petr Mladek
2018-04-06 14:19       ` Joe Perches
2018-04-09 11:44         ` Petr Mladek
2018-04-09 11:59           ` Joe Perches
2018-04-04  8:58 ` [PATCH v4 7/9] vsprintf: Factor out %pO handler as kobject_string() Petr Mladek
2018-04-04 23:35   ` Sergey Senozhatsky
2018-04-04 23:43     ` Sergey Senozhatsky
2018-04-05 14:02     ` Petr Mladek
2018-04-04  8:58 ` [PATCH v4 8/9] vsprintf: Prevent crash when dereferencing invalid pointers Petr Mladek
2018-04-05 14:46   ` Rasmus Villemoes
2018-04-06 12:26     ` Petr Mladek
2018-04-06 13:12       ` Rasmus Villemoes
2018-04-10 13:26         ` Petr Mladek
2018-04-06  9:37   ` Rasmus Villemoes
2018-04-04  8:58 ` [PATCH v4 9/9] vsprintf: Avoid confusion between invalid address and value Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180404085843.16050-7-pmladek@suse.com \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=me@tobin.cc \
    --cc=mhocko@suse.cz \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.