From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v5 1/3] Add Intel FPGA BUS Library Date: Wed, 4 Apr 2018 10:55:10 +0100 Message-ID: <20180404095510.GB14376@bricha3-MOBL.ger.corp.intel.com> References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1522824677-86958-1-git-send-email-rosen.xu@intel.com> <1522824677-86958-2-git-send-email-rosen.xu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, declan.doherty@intel.com, shreyansh.jain@nxp.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, tianfei.zhang@intel.com, hao.wu@intel.com, gaetan.rivet@6wind.com To: Rosen Xu Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id A4C451BB2C for ; Wed, 4 Apr 2018 11:55:15 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1522824677-86958-2-git-send-email-rosen.xu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 04, 2018 at 02:51:15PM +0800, Rosen Xu wrote: > Signed-off-by: Rosen Xu Please include a description of this patch in the commit message. The cover letter is not going to be part of the commit history, after all. Therefore, move or copy relevant parts of the cover letter to the commit message here, so that someone viewing the git log gets a good overview of this work. > --- > config/common_base | 5 + > drivers/bus/Makefile | 1 + > drivers/bus/ifpga/Makefile | 32 ++ > drivers/bus/ifpga/ifpga_bus.c | 504 ++++++++++++++++++++++++++++ > drivers/bus/ifpga/ifpga_common.c | 88 +++++ > drivers/bus/ifpga/ifpga_common.h | 18 + > drivers/bus/ifpga/ifpga_logs.h | 31 ++ > drivers/bus/ifpga/rte_bus_ifpga.h | 168 ++++++++++ > drivers/bus/ifpga/rte_bus_ifpga_version.map | 10 + > mk/rte.app.mk | 2 + Need to add this to the meson build too. If you are unfamiliar with building DPDK with meson see "doc/build-sdk-meson.txt". /Bruce