From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Maxime Ripard Subject: [PATCH v8 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller Date: Wed, 4 Apr 2018 14:20:23 +0200 Message-Id: <20180404122025.8726-1-maxime.ripard@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: Mauro Carvalho Chehab , Mark Rutland , Rob Herring , Frank Rowand Cc: Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Richard Sproul , Alan Douglas , Steve Creaney , Thomas Petazzoni , Boris Brezillon , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Hans Verkuil , Sakari Ailus , Benoit Parrot , nm@ti.com, Simon Hatliff , Maxime Ripard List-ID: Hi, Here is an attempt at supporting the MIPI-CSI2 TX block from Cadence. This IP block is able to receive 4 video streams and stream them over a MIPI-CSI2 link using up to 4 lanes. Those streams are basically the interfaces to controllers generating some video signals, like a camera or a pattern generator. It is able to map input streams to CSI2 virtual channels and datatypes dynamically. The streaming devices choose their virtual channels through an additional signal that is transparent to the CSI2-TX. The datatypes however are yet another additional input signal, and can be mapped to any CSI2 datatypes. Since v4l2 doesn't really allow for that setup at the moment, this preliminary version is a rather dumb one in order to start the discussion on how to address this properly. Let me know what you think! Maxime Changes from v7: - Removed unused headers - Fixed a function prefix inconsistency - Added Niklas' Reviewed-by Changes from v6: - Added Niklas Reviewed-by on the bindings - Added MODULE_LICENSE, MODULE_DESCRIPTION and MODULE_AUTHOR Changes from v5: - Changed the return type to void for csi2tx_stop - Checked for the pad index in get/set_pad_format - Made a comment that the DPHY registers are for the DPHY *interface* register Changes from v4: - After playing a bit with the pad multiplexing patches, found that it was making much more sense to have the subdev notifiers for the source subdev rather for the sink that might even be outside of Linux control. Removed the notifier for now. Changes from v3: - Added a comment about entity links walk concurrency - Changed the default resolution to 1280x720 - Changed usleep_range calls to udelay - Reworked the reference counting mechanism to remove a race condition by adding a mutex instead of an atomic count - Changed the entity function to MEDIA_ENT_F_VID_IF_BRIDGE - Changed the name of the reg variable in _get_resources to dev_cfg - Removed the redundant error message in the devm_ioremap_resource error path - Moved the subdev s_stream call before enabling the TX bridge - Changed some int types to unsigned - Init'd the pad formats properly - Fixed typo in the CSI2TX_LANES_MAX define name - Added Sakari Acked-by Changes from v2: - Use SPDX license header - Use the lane mapping from DT Changes from v1: - Add a subdev notifier and start our downstream subdevice in s_stream - Based the decision to enable the stream or not on the link state instead of whether a format was being set on the pad - Put the controller back in reset when stopping the pipeline - Clarified the enpoints number in the DT binding - Added a default format for the pads - Added some missing const - Added more explicit comments - Rebased on 4.15 Maxime Ripard (2): dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings v4l: cadence: Add Cadence MIPI-CSI2 TX driver .../devicetree/bindings/media/cdns,csi2tx.txt | 98 ++++ drivers/media/platform/cadence/Kconfig | 11 + drivers/media/platform/cadence/Makefile | 1 + drivers/media/platform/cadence/cdns-csi2tx.c | 529 +++++++++++++++++++++ 4 files changed, 639 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2tx.txt create mode 100644 drivers/media/platform/cadence/cdns-csi2tx.c -- 2.14.3