From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Subject: Re: [PATCH v3 1/2] eal: add API to align integer to previous power of 2 Date: Wed, 4 Apr 2018 23:45:58 +0530 Message-ID: <20180404181557.GA30549@ltp-pvn> References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <20180404101606.5156-1-pbhagavatula@caviumnetworks.com> <20180404164207.GA21153@ltp-pvn> <20180404175156.GA5416@ltp-pvn> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Matan Azrad , "jerin.jacob@caviumnetworks.com" , "keith.wiles@intel.com" , Thomas Monjalon Return-path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0043.outbound.protection.outlook.com [104.47.37.43]) by dpdk.org (Postfix) with ESMTP id E86F71B7B0 for ; Wed, 4 Apr 2018 20:16:21 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, > > Got you. > Looks like you found issue here... > The experimental tag probably should be in a root .h file. > Probably, need a fix patch to move it for a different\new .h file. > > What do you think? > Actually thats just start of the rabbit hole, if we succeed to tag a inline function in rte_common.h as experimental every lib/driver that uses rte_common.h (almost everything) needs to have CFLAGS set to -DALLOW_EXPERIMENTAL_API. Regards, Pavan.