From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1F4261F404 for ; Wed, 4 Apr 2018 19:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751560AbeDDTqK (ORCPT ); Wed, 4 Apr 2018 15:46:10 -0400 Received: from cloud.peff.net ([104.130.231.41]:53620 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751419AbeDDTqJ (ORCPT ); Wed, 4 Apr 2018 15:46:09 -0400 Received: (qmail 19813 invoked by uid 109); 4 Apr 2018 19:46:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Wed, 04 Apr 2018 19:46:09 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7528 invoked by uid 111); 4 Apr 2018 19:47:10 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Wed, 04 Apr 2018 15:47:10 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 04 Apr 2018 15:46:07 -0400 Date: Wed, 4 Apr 2018 15:46:07 -0400 From: Jeff King To: Derrick Stolee Cc: Derrick Stolee , git@vger.kernel.org, avarab@gmail.com, sbeller@gmail.com, larsxschneider@gmail.com, bmwill@google.com Subject: Re: [PATCH 7/6] ref-filter: use generation number for --contains Message-ID: <20180404194607.GA14395@sigill.intra.peff.net> References: <20180403190500.GA10930@sigill.intra.peff.net> <20180404154554.140716-1-dstolee@microsoft.com> <20180404182242.GA9055@sigill.intra.peff.net> <1cc07683-8d2e-e9fa-ffee-2663057704be@gmail.com> <20180404191657.GA13543@sigill.intra.peff.net> <20180404194248.GA14055@sigill.intra.peff.net> <8a830161-ece7-44ba-e9f2-11073bd23802@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8a830161-ece7-44ba-e9f2-11073bd23802@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Apr 04, 2018 at 03:45:30PM -0400, Derrick Stolee wrote: > On 4/4/2018 3:42 PM, Jeff King wrote: > > On Wed, Apr 04, 2018 at 03:22:01PM -0400, Derrick Stolee wrote: > > > > > That is the idea. I should make this clearer in all of my commit messages. > > Yes, please. :) And maybe in the documentation of the file format, if > > it's not there (I didn't check). It's a very useful property, and we > > want to make sure people making use of the graph know they can depend on > > it. > > For v2, I'll expand on the roles of _UNDEF and _NONE in the discussion of > generation numbers in Documentation/technical/commit-graph.txt (the design > doc instead of the file format). Yeah, that makes sense. Thanks, and thanks for a thoughtful discussion. The performance numbers are very exciting. -Peff