Hi Stefan,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16 next-20180404]
[cannot apply to battery/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Stefan-Popa/adp5061-New-driver-for-ADP5061-I2C-battery-charger/20180405-000342
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/kobject.h:20:0,
                    from include/linux/module.h:17,
                    from drivers/power/supply/adp5061.c:10:
>> drivers/power/supply/adp5061.c:739:23: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
    static DEVICE_ATTR_RW(charging_enabled);
                          ^
   include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
     .show = _show,      \
             ^~~~~
   include/linux/device.h:581:45: note: in expansion of macro '__ATTR_RW'
     struct device_attribute dev_attr_##_name = __ATTR_RW(_name)
                                                ^~~~~~~~~
>> drivers/power/supply/adp5061.c:739:8: note: in expansion of macro 'DEVICE_ATTR_RW'
    static DEVICE_ATTR_RW(charging_enabled);
           ^~~~~~~~~~~~~~
   drivers/power/supply/adp5061.c:739:23: note: (near initialization for 'dev_attr_charging_enabled.show')
    static DEVICE_ATTR_RW(charging_enabled);
                          ^
   include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
     .show = _show,      \
             ^~~~~
   include/linux/device.h:581:45: note: in expansion of macro '__ATTR_RW'
     struct device_attribute dev_attr_##_name = __ATTR_RW(_name)
                                                ^~~~~~~~~
>> drivers/power/supply/adp5061.c:739:8: note: in expansion of macro 'DEVICE_ATTR_RW'
    static DEVICE_ATTR_RW(charging_enabled);
           ^~~~~~~~~~~~~~
>> drivers/power/supply/adp5061.c:739:23: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
    static DEVICE_ATTR_RW(charging_enabled);
                          ^
   include/linux/sysfs.h:105:11: note: in definition of macro '__ATTR'
     .store = _store,      \
              ^~~~~~
   include/linux/device.h:581:45: note: in expansion of macro '__ATTR_RW'
     struct device_attribute dev_attr_##_name = __ATTR_RW(_name)
                                                ^~~~~~~~~
>> drivers/power/supply/adp5061.c:739:8: note: in expansion of macro 'DEVICE_ATTR_RW'
    static DEVICE_ATTR_RW(charging_enabled);
           ^~~~~~~~~~~~~~
   drivers/power/supply/adp5061.c:739:23: note: (near initialization for 'dev_attr_charging_enabled.store')
    static DEVICE_ATTR_RW(charging_enabled);
                          ^
   include/linux/sysfs.h:105:11: note: in definition of macro '__ATTR'
     .store = _store,      \
              ^~~~~~
   include/linux/device.h:581:45: note: in expansion of macro '__ATTR_RW'
     struct device_attribute dev_attr_##_name = __ATTR_RW(_name)
                                                ^~~~~~~~~
>> drivers/power/supply/adp5061.c:739:8: note: in expansion of macro 'DEVICE_ATTR_RW'
    static DEVICE_ATTR_RW(charging_enabled);
           ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +739 drivers/power/supply/adp5061.c

   738	
 > 739	static DEVICE_ATTR_RW(charging_enabled);
   740	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation