From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration Date: Thu, 5 Apr 2018 07:36:38 +0200 Message-ID: <20180405053638.GA10118@nanopsycho> References: <20180329203334.25575-1-idosch@mellanox.com> <20180329203334.25575-10-idosch@mellanox.com> <5f2dc834-0d8a-77ef-3d33-2228e7bd530c@gmail.com> <20180403073212.GI3313@nanopsycho> <20180403153020.GJ3313@nanopsycho> <289e6c36-5e8d-139a-9fa4-575cf9fe86a1@gmail.com> <20180404062511.GO3313@nanopsycho> <20180404155910.7baf2ec9@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jakub Kicinski , Ido Schimmel , netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com To: David Ahern Return-path: Received: from mail-wr0-f175.google.com ([209.85.128.175]:33930 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbeDEFgk (ORCPT ); Thu, 5 Apr 2018 01:36:40 -0400 Received: by mail-wr0-f175.google.com with SMTP id d17so10862165wre.1 for ; Wed, 04 Apr 2018 22:36:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Thu, Apr 05, 2018 at 01:00:18AM CEST, dsahern@gmail.com wrote: >On 4/4/18 4:59 PM, Jakub Kicinski wrote: >> On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: >>>> Jiri, I am not aware of any other API where a driver registers with it >>>> yet doesn't want the handler to be called so either waits to register >>> >>> Again, the thing is, this is kind of unusual because of the reload >>> thing. >> >> FWIW my knee jerk thought is that it's strange that devlink ops can >> be executed at all while reload is happening (incl. another reload >> request). I'm probably missing the real issue.. >> > >Just responding with the same question ... > >Why are you not unregistering resources on a reload? Because you need the use the values of course!