From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:55898 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbeDEHQA (ORCPT ); Thu, 5 Apr 2018 03:16:00 -0400 Date: Thu, 5 Apr 2018 00:16:00 -0700 From: Christoph Hellwig Subject: Re: [PATCH 6/6] xfs: delay quota timelimit init until after quotacheck Message-ID: <20180405071600.GF17256@infradead.org> References: <49eeb340-2ff2-c274-d26b-fd8edd982d61@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49eeb340-2ff2-c274-d26b-fd8edd982d61@sandeen.net> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: linux-xfs On Wed, Apr 04, 2018 at 02:12:40PM -0500, Eric Sandeen wrote: > Initializing the time limits in the quota info requires reading > the default quota block. If it's corrupt, this yields even more > dmesg spew before kernelspace gets around to properly detecting > and repairing the corruption. > > If we move the read and initialization until post-quotacheck, > we can avoid the noisy read if it's corrupted. > > Signed-off-by: Eric Sandeen Looks good, Reviewed-by: Christoph Hellwig