From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_getfb: Use fixtures and subtest groups
Date: Thu, 5 Apr 2018 12:18:34 +0300 [thread overview]
Message-ID: <20180405091834.GA14489@ahiler-desk1.ger.corp.intel.com> (raw)
In-Reply-To: <CAPj87rOCKShi9+FLvgC2koqKppHM3EOiiBvc8+b37EWba+8NkA@mail.gmail.com>
On Wed, Apr 04, 2018 at 05:28:13PM +0100, Daniel Stone wrote:
> Hi Arkadiusz,
>
> On 4 April 2018 at 15:00, Arkadiusz Hiler <arkadiusz.hiler@intel.com> wrote:
> > On Mon, Apr 02, 2018 at 10:13:19AM -0700, Antonio Argenziano wrote:
> >> On 02/04/18 06:02, Daniel Stone wrote:
> >> > To be clear, does this mean that each piece of fixture and igt_subtest
> >> > definition should live inside main?
> >>
> >> I don't think there is a rule for that, it looks better that way
> >> (fixtures/igt_subtest/subtest_group all in the main) IMO :). Also it is what
> >> I've found in most if not all tests I've looked at.
> >
> > Definately not a rule, and definately not a patch to enforce such
> > preference :-P
> >
> > But generally it's a good default.
>
> Thanks for pushing this. I haven't done the rework yet because I've
> been busy with some more urgent fires this week; I'll rewrite
> everything to be directly under main() later this week.
>
> Cheers,
> Daniel
There's no real need. The test is easy to follow as it is and I
personally like the grouping done this way.
As I've said - it's just a good default and not much more.
--
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-04-05 9:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 15:49 [igt-dev] [PATCH i-g-t] tests/kms_getfb: Use fixtures and subtest groups Daniel Stone
2018-03-30 16:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-30 17:47 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2018-03-30 18:20 ` Daniel Stone
2018-03-30 21:01 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
2018-04-02 13:02 ` Daniel Stone
2018-04-02 17:13 ` Antonio Argenziano
2018-04-04 14:00 ` Arkadiusz Hiler
2018-04-04 16:28 ` Daniel Stone
2018-04-05 9:18 ` Arkadiusz Hiler [this message]
2018-04-05 8:44 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405091834.GA14489@ahiler-desk1.ger.corp.intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=daniel@fooishbar.org \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.