From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f43Qi-00066o-T8 for mharc-grub-devel@gnu.org; Thu, 05 Apr 2018 07:51:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f43Qd-000647-Ov for grub-devel@gnu.org; Thu, 05 Apr 2018 07:51:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f43QY-0004Cb-St for grub-devel@gnu.org; Thu, 05 Apr 2018 07:51:43 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:51586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f43QY-0004BL-JI for grub-devel@gnu.org; Thu, 05 Apr 2018 07:51:38 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w35BpVPY145908; Thu, 5 Apr 2018 11:51:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=fNLFPNzrL4tfB3pC3HCaBIBTgOKiobV1l6n434XqSsk=; b=aZGj8oNhW+8wnAPTVenBQlBS07+IubEtXazwyXOzo6qQwIgOF1dRtL9bir0rEIb/N/Pt enIyn7wvCmRVsko8kb62X6WtJ8e9l2FyDqU25p33wpqgF/wdZw7xj66tDik3adTIH3tH uyTeIgX5DB47nEO17i9tL5kCaiqC/bY5wrsWZv5L52EXNQme2BW9O5WK0DnCN0acfwe9 JP1zQ/OwewkFkl7QWBmzL0WXfQy1H11BD2U1fsggyPD8p2KaPXAtpaIi4IdnD+Etri0V aTDE8qs+ktRx0RSPPoUa7tmG/NUIMdgwB1nE32VB/CrZi70FnqHo8QzjihbQwbRFBbkS eQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2h5k4b80sb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Apr 2018 11:51:31 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w35BlEhN004231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Apr 2018 11:47:15 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w35BlE4B020682; Thu, 5 Apr 2018 11:47:14 GMT Received: from olila.local.net-space.pl (/10.175.208.178) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Apr 2018 04:47:13 -0700 Date: Thu, 5 Apr 2018 13:47:10 +0200 From: Daniel Kiper To: Hans de Goede Cc: Lennart Sorensen , The development of GNU GRUB Subject: Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys Message-ID: <20180405114710.GS26100@olila.local.net-space.pl> References: <20180328145028.21555-1-hdegoede@redhat.com> <20180328145028.21555-3-hdegoede@redhat.com> <20180328145631.7rqxej4yrn5keydr@csclub.uwaterloo.ca> <551a4dfe-9ed6-ef5e-196a-b8e3fc0d3f54@redhat.com> <20180328151152.iat3ti3hxiehrreb@csclub.uwaterloo.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8853 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804050119 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.85 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 11:51:48 -0000 On Wed, Mar 28, 2018 at 05:58:16PM +0200, Hans de Goede wrote: > Hi, > > On 28-03-18 17:11, Lennart Sorensen wrote: > >On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: > >>Hmm, well people will still be able to use ESC to get the grub boot > >>menu, rather then the firmware boot-menu on those. > >> > >>The problem is that our current check for ESC only approach is problematic > >>because it conflicts with the enter firmware-setup key on almost all Bay Trail, > >>Cherry Trail and Apollo Lake devices. You need to try hard to find a device > >>in one of those 3 categories which does not use ESC for this. Note I'm > >>aware some devices exist, but using ESC for this is really really common > >>among these devices. > >> > >>I'm open to other suggestions, but I think we really need to add another > >>key to avoid the pressing ESC at boot already has another meaning problem > >>and F8 seems like an ok choice. > >> > >>Either way thank you for the input on this. > > > >I don't disagree about having another key, I just disagree that F8 is > >a good choice. > > > >Looking at https://kb.wisc.edu/page.php?id=58779#here it appears no one > >uses F4 for anything. That would seem like a better choice than F8 > >at least. F6 also seems to be free but F4 seems nicer on desktop > >keyboards. > > Looking at that table I have to agree that F4 seems like the best second > key to use. Actually looking at that table ESC seems like a poor choice, > but I guess it makes sense for serial-terminals as well as from a general > UI pov (and we're stuck with it now anyways). > > I'm going to wait for Daniel's review of the other patches before I do > a v2 of this patch-set. I will switch to F4 for v2. Please leave ESC as is and add F4 key. Though I would provide an option to change the defaults at runtime. Daniel