All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Thomas Hellstrom <thellstrom@vmware.com>,
	VMware Graphics <linux-graphics-maintainer@vmware.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 1/9] drm/vmwgfx: Remove no-op prepare/cleanup_fb callbacks
Date: Thu,  5 Apr 2018 17:44:41 +0200	[thread overview]
Message-ID: <20180405154449.23038-2-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20180405154449.23038-1-daniel.vetter@ffwll.ch>

Less hits to go through when I git grep over all drivers. These
callbacks are optional.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Sinclair Yeh <syeh@vmware.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 35 -----------------------------------
 1 file changed, 35 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
index 3824595fece1..4a5907e3f560 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
@@ -281,39 +281,6 @@ drm_connector_helper_funcs vmw_ldu_connector_helper_funcs = {
  * Legacy Display Plane Functions
  */
 
-/**
- * vmw_ldu_primary_plane_cleanup_fb - Noop
- *
- * @plane:  display plane
- * @old_state: Contains the FB to clean up
- *
- * Unpins the display surface
- *
- * Returns 0 on success
- */
-static void
-vmw_ldu_primary_plane_cleanup_fb(struct drm_plane *plane,
-				 struct drm_plane_state *old_state)
-{
-}
-
-
-/**
- * vmw_ldu_primary_plane_prepare_fb - Noop
- *
- * @plane:  display plane
- * @new_state: info on the new plane state, including the FB
- *
- * Returns 0 on success
- */
-static int
-vmw_ldu_primary_plane_prepare_fb(struct drm_plane *plane,
-				 struct drm_plane_state *new_state)
-{
-	return 0;
-}
-
-
 static void
 vmw_ldu_primary_plane_atomic_update(struct drm_plane *plane,
 				    struct drm_plane_state *old_state)
@@ -373,8 +340,6 @@ static const struct
 drm_plane_helper_funcs vmw_ldu_primary_plane_helper_funcs = {
 	.atomic_check = vmw_du_primary_plane_atomic_check,
 	.atomic_update = vmw_ldu_primary_plane_atomic_update,
-	.prepare_fb = vmw_ldu_primary_plane_prepare_fb,
-	.cleanup_fb = vmw_ldu_primary_plane_cleanup_fb,
 };
 
 static const struct drm_crtc_helper_funcs vmw_ldu_crtc_helper_funcs = {
-- 
2.16.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-04-05 15:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 15:44 [PATCH 0/9] implicit fencing clarification Daniel Vetter
2018-04-05 15:44 ` Daniel Vetter [this message]
2018-04-05 17:06   ` [PATCH 1/9] drm/vmwgfx: Remove no-op prepare/cleanup_fb callbacks Thomas Hellstrom
2018-04-05 19:59     ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 2/9] drm: Move simple_display_pipe prepare_fb helper into gem fb helpers Daniel Vetter
2018-04-06  9:42   ` Noralf Trønnes
2018-04-09  8:42     ` Daniel Vetter
2018-04-09 15:23   ` David Lechner
2018-04-10  5:55   ` Oleksandr Andrushchenko
2018-04-05 15:44 ` [PATCH 3/9] drm/tve200: Use simple_display_pipe prepare_fb helper Daniel Vetter
2018-04-06  9:40   ` Linus Walleij
2018-04-05 15:44 ` [PATCH 4/9] drm/pl111: " Daniel Vetter
2018-04-05 15:44 ` [PATCH 5/9] drm/mxsfb: " Daniel Vetter
2018-04-20 21:54   ` Eric Anholt
2018-04-05 15:44 ` [PATCH 6/9] drm/atomic: better doc for implicit vs explicit fencing Daniel Vetter
2018-04-20 22:04   ` Eric Anholt
2018-04-24 12:01     ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 7/9] drm/gem-fb-helper: Always do implicit sync Daniel Vetter
2018-04-20 22:11   ` Eric Anholt
2018-04-24 12:04     ` Daniel Vetter
2018-06-20 12:46       ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 8/9] drm/vc4: Always obey " Daniel Vetter
2018-04-20 22:12   ` Eric Anholt
     [not found] ` <20180405154449.23038-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-04-05 15:44   ` [PATCH 9/9] drm/msm: Always obey implicit fencing Daniel Vetter
     [not found]     ` <20180405154449.23038-10-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-06-20  9:12       ` Daniel Vetter
2018-04-06  7:38 ` [PATCH 0/9] implicit fencing clarification Oleksandr Andrushchenko
2018-04-09  8:44   ` Daniel Vetter
2018-04-09  8:51   ` [PATCH] drm/xen-front: use simple display pipe prepare_fb helper Daniel Vetter
2018-04-09  8:51   ` Daniel Vetter
2018-04-10  5:56     ` Oleksandr Andrushchenko
2018-04-10  5:56     ` Oleksandr Andrushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180405154449.23038-2-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.