From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrew Morton <akpm@linux-foundation.org>, dave.hansen@intel.com
Cc: Baoquan He <bhe@redhat.com>,
linux-kernel@vger.kernel.org, pagupta@redhat.com,
linux-mm@kvack.org, kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v3 0/4] mm/sparse: Optimize memmap allocation during sparse_init()
Date: Fri, 6 Apr 2018 14:05:57 +0300 [thread overview]
Message-ID: <20180406110557.xg2edtjgzmsdksry@node.shutemov.name> (raw)
In-Reply-To: <20180405150842.350e4febc06a813138f00416@linux-foundation.org>
On Thu, Apr 05, 2018 at 03:08:42PM -0700, Andrew Morton wrote:
> On Wed, 28 Feb 2018 11:26:53 +0800 Baoquan He <bhe@redhat.com> wrote:
>
> > This is v3 post. V1 can be found here:
> > https://www.spinics.net/lists/linux-mm/msg144486.html
> >
> > In sparse_init(), two temporary pointer arrays, usemap_map and map_map
> > are allocated with the size of NR_MEM_SECTIONS. They are used to store
> > each memory section's usemap and mem map if marked as present. In
> > 5-level paging mode, this will cost 512M memory though they will be
> > released at the end of sparse_init(). System with few memory, like
> > kdump kernel which usually only has about 256M, will fail to boot
> > because of allocation failure if CONFIG_X86_5LEVEL=y.
> >
> > In this patchset, optimize the memmap allocation code to only use
> > usemap_map and map_map with the size of nr_present_sections. This
> > makes kdump kernel boot up with normal crashkernel='' setting when
> > CONFIG_X86_5LEVEL=y.
>
> This patchset could do with some more review, please?
I don't really understand sparsemem good enough to comment on the
patchset.
Dave, could you review this?
--
Kirill A. Shutemov
prev parent reply other threads:[~2018-04-06 11:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 3:26 [PATCH v3 0/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-02-28 3:26 ` Baoquan He
2018-02-28 3:26 ` [PATCH v3 1/4] mm/sparse: Add a static variable nr_present_sections Baoquan He
2018-02-28 3:26 ` Baoquan He
2018-02-28 3:26 ` [PATCH v3 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing Baoquan He
2018-02-28 3:26 ` Baoquan He
2018-04-06 14:23 ` Dave Hansen
2018-04-08 6:50 ` Baoquan He
2018-04-09 16:02 ` Dave Hansen
2018-04-10 0:26 ` Baoquan He
2018-02-28 3:26 ` [PATCH v3 3/4] mm/sparse: Add a new parameter 'data_unit_size' for alloc_usemap_and_memmap Baoquan He
2018-02-28 3:26 ` Baoquan He
2018-02-28 3:26 ` [PATCH v3 4/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-02-28 3:26 ` Baoquan He
2018-04-06 14:50 ` Dave Hansen
2018-04-08 8:20 ` Baoquan He
2018-04-09 2:07 ` Baoquan He
2018-04-11 15:48 ` Dave Hansen
2018-04-15 2:19 ` Baoquan He
2018-04-16 4:36 ` Dave Hansen
2018-04-05 22:08 ` [PATCH v3 0/4] " Andrew Morton
2018-04-06 11:05 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406110557.xg2edtjgzmsdksry@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pagupta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.