From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f4Pkb-0001si-DO for mharc-grub-devel@gnu.org; Fri, 06 Apr 2018 07:41:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4PkY-0001pC-JJ for grub-devel@gnu.org; Fri, 06 Apr 2018 07:41:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4PkT-00059I-Iw for grub-devel@gnu.org; Fri, 06 Apr 2018 07:41:46 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:59216) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f4PkT-00058x-A8 for grub-devel@gnu.org; Fri, 06 Apr 2018 07:41:41 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w36B3uPQ106125; Fri, 6 Apr 2018 11:41:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=gcbc9WWSa7sRO5XNSgGqI2LhQw0ZluEAEuu0TN4OPEw=; b=DlSfSzQfTT68XAvRqldzsJPoIrrnLNfS6yhE0SVWDCKF6kiPBPglsW8L/ZgMC1Lx5s8X GVybTnRVG74WGXThWDYdDgORnaRCmFLQgj2Ivv3oHxXdIJE/QNUOSiATpa3RAdd2lyYE Bu2/b8rwFeZycKjaWL1P7NhlO/1zuvb3OYmb734a0kyAjCjm0TmeejAB1xoAtbXbQ2kR 0+6FVok6juyhN1PRSa4TADxhulWimOiWECXL0b+EASSTRdzmhKJQM8zI6W4Jm5237zYr 7Nz62befR1sJLpjD0IneVumX34rohFggtXtqun02BwEXPHQAhUyplIhxg8H19bwPMscA SA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2h5k57vp6k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Apr 2018 11:41:39 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w36BfcgC027014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Apr 2018 11:41:39 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w36BfcuR013338; Fri, 6 Apr 2018 11:41:38 GMT Received: from olila.local.net-space.pl (/10.175.209.68) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 06 Apr 2018 04:41:37 -0700 Date: Fri, 6 Apr 2018 13:41:34 +0200 From: Daniel Kiper To: Hans de Goede Cc: grub-devel@gnu.org, Colin Watson Subject: Re: [PATCH 3/4] Optionally print less messages at boot Message-ID: <20180406114134.GW26100@olila.local.net-space.pl> References: <20180328145028.21555-1-hdegoede@redhat.com> <20180328145028.21555-4-hdegoede@redhat.com> <20180405121257.GT26100@olila.local.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8854 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804060118 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.86 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 11:41:47 -0000 On Thu, Apr 05, 2018 at 07:53:23PM +0200, Hans de Goede wrote: > Hi, > > On 05-04-18 14:12, Daniel Kiper wrote: > >On Wed, Mar 28, 2018 at 04:50:27PM +0200, Hans de Goede wrote: > >>The patch optionally makes grub not show any text (be fully quiet) when > >>timeout_style=hidden is set and the user does not interrupt the boot. > >> > >>Combined with a later patch in this series which makes grub not touch > >>the EFI console unless it actually has some text to print, this will keep > >>the vendor logo which EFI put on the display in place until the kernel > >>touches the display. Leading to a more smooth / seamless boot experience. > >> > >>At least Fedora/RHEL/CentOS and Ubuntu have been carrying patches for this > >>for a long time now (since 2013). There have been several attempts to > >>upstream these patches in the past already, which have been rejected > >>because not everyone likes the quiet behavior. > > > >May I ask you to provide links to the relevant conversations? > > Sure you may ask, but I cannot really help with that because I was not > involved in grub development back then. > > I've done a quick search of the mailinglist archives, but > I'm afraid I could not find anything that way. OK, let's leave it. > >>This patch makes the quiet behavior optional and defaults to off, so > >>unless grub is compiled with the new --enable-quiet-boot configure option > >>this patch changes nothing. > > > >I am not sure why this should be build time option. I would see this as > >a runtime option, e.g. boot_quiet shell variable or even timeout_style=quiet. > >Hmmm... Latter is probably preferred. > > The problem is that grub already prints various things before reading > its environment or config file. > > What I've understood from the history of this patches, removing those > earlier prints (see e.g. the grub-core/boot/i386/pc/boot.S change in > this patch) was objected against because that provides info that at > least the first stage (for a classic PC BIOS boot setup) has successfully > loaded. > > The menu code itself is already quiet when using timeout_style=hidden, > the problem is the messages printed before (and after) the menu code. > > If you're happy with killing the messages shown before the config file > is loaded (as most distros already do), then the rest could be made runtime > configurable. If they are printed deliberately I am not happy with killing them blindly. However, I think that it can be done in other way. Could we add an option to grub-mkimage (and other tools if it is needed) which disables printing of these messages? Daniel