[PATCH] tools/kdd: use mute -Warray-bounds only on new gcc version - Marek Marczykowski-Górecki

From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: xen-devel@lists.xen.org
Cc: "Ian Jackson" <ian.jackson@eu.citrix.com>,
	"Tim Deegan" <tim@xen.org>,
	"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
	"Wei Liu" <wei.liu2@citrix.com>
Subject: [PATCH] tools/kdd: use mute -Warray-bounds only on new gcc version
Date: Fri,  6 Apr 2018 17:32:57 +0200	[thread overview]
Message-ID: <20180406153258.29262-1-marmarek@invisiblethingslab.com> (raw)
In-Reply-To: <20180406151246.c5s6zig3m73bcmb4@citrix.com>

"#pragma GCC diagnostic push" is supported only on gcc >= 4.6. But since
muting this the warning is needed only on gcc >= 8, do it only then,
instead of tricking the compiler about this code (and making it less
readable to the human too).

This fixes 5888eecca0 "tools/kdd: mute spurious gcc warning".

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
 tools/debugger/kdd/kdd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/kdd/kdd.c
index 61d769ece9..95c3a949ec 100644
--- a/tools/debugger/kdd/kdd.c
+++ b/tools/debugger/kdd/kdd.c
@@ -695,10 +695,14 @@ static void kdd_handle_read_ctrl(kdd_state *s)
             KDD_LOG(s, "Request outside of known control space\n");
             len = 0;
         } else {
+#if __GNUC__ >= 8
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
             memcpy(buf, ((uint8_t *)&ctrl.c32) + offset, len);
+#if __GNUC__ >= 8
 #pragma GCC diagnostic pop
+#endif
         }
     }
 
-- 
2.13.6


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
