All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 4/4] perf, tools, record: Remove suggestion to enable APIC
Date: Fri,  6 Apr 2018 13:38:12 -0700	[thread overview]
Message-ID: <20180406203812.3087-5-andi@firstfloor.org> (raw)
In-Reply-To: <20180406203812.3087-1-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

perf record suggests to enable the APIC on errors.

APIC is practically always used today and the problem is usually somewhere else.

Just remove the outdated suggestion.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/util/evsel.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 66b62570c855..3e87486c28fe 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2870,8 +2870,7 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
 #if defined(__i386__) || defined(__x86_64__)
 		if (evsel->attr.type == PERF_TYPE_HARDWARE)
 			return scnprintf(msg, size, "%s",
-	"No hardware sampling interrupt available.\n"
-	"No APIC? If so then you can boot the kernel with the \"lapic\" boot parameter to force-enable it.");
+	"No hardware sampling interrupt available.\n");
 #endif
 		break;
 	case EBUSY:
-- 
2.14.3

  parent reply	other threads:[~2018-04-06 20:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 20:38 Some minor fixes for perf user tools Andi Kleen
2018-04-06 20:38 ` [PATCH 1/4] perf, tools, mem: Allow all record/report options Andi Kleen
2018-04-21  7:50   ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 2/4] perf, tools: Clarify browser help Andi Kleen
2018-04-21  7:51   ` [tip:perf/urgent] perf hists browser: Clarify top/report " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 3/4] perf, tools, record: Remove misleading error suggestion Andi Kleen
2018-04-21  7:51   ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-06 20:38 ` Andi Kleen [this message]
2018-04-21  7:52   ` [tip:perf/urgent] perf record: Remove suggestion to enable APIC tip-bot for Andi Kleen
2018-04-13 13:13 ` Some minor fixes for perf user tools Jiri Olsa
2018-04-13 14:33   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180406203812.3087-5-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.