From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v4 10/20] eal/dev: implement device iteration
Date: Mon, 9 Apr 2018 10:16:25 +0200
Message-ID: <20180409081625.amvkpxp2ctthsxg5@bidouze.vm.6wind.com>
References: <cover.1522358419.git.gaetan.rivet@6wind.com>
 <5d94711adb1333f2d4ef1f4a081ccd481f3810aa.1522358421.git.gaetan.rivet@6wind.com>
 <AM4PR0501MB26573E4DB474FA96A7435C03D2BF0@AM4PR0501MB2657.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Matan Azrad <matan@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com
 [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id EBAD91B783
 for <dev@dpdk.org>; Mon,  9 Apr 2018 10:16:39 +0200 (CEST)
Received: by mail-wr0-f179.google.com with SMTP id s12so8372828wrc.8
 for <dev@dpdk.org>; Mon, 09 Apr 2018 01:16:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <AM4PR0501MB26573E4DB474FA96A7435C03D2BF0@AM4PR0501MB2657.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 09, 2018 at 07:28:00AM +0000, Matan Azrad wrote:
> HI Gaetan
> 
> From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM
> > +/* '\0' forbidden in sym */
> > +static const char *
> > +strfirstof(const char *str,
> > +	   const char *sym)
> > +{
> > +	const char *s;
> > +
> > +	for (s = str; s[0] != '\0'; s++) {
> > +		const char *c;
> > +
> > +		for (c = sym; c[0] != '\0'; c++) {
> > +			if (c[0] == s[0])
> > +				return s;
> > +		}
> > +	}
> > +	return NULL;
> > +}
> > +
> 
> I think you can use strcspn() instead...
> 

Indeed, didn't know about it, I will change it.

-- 
Gaëtan Rivet
6WIND