From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbeDIPRf (ORCPT ); Mon, 9 Apr 2018 11:17:35 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:39918 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028AbeDIPRd (ORCPT ); Mon, 9 Apr 2018 11:17:33 -0400 X-Google-Smtp-Source: AIpwx4/VKeUwLGxpaNrntRHe2seTetcAw/n1Ya0ncyBDiBGuuf9T4BbO78mxnQhC4Lebh2vDAX3Bpw== Date: Mon, 9 Apr 2018 17:17:28 +0200 From: Luc Van Oostenryck To: Geert Uytterhoeven Cc: Finn Thain , Laurent Vivier , Jens Axboe , linux-m68k , Linux Kernel Mailing List Subject: Re: [PATCH 03/12] m68k/mac: Don't remap SWIM MMIO region Message-ID: <20180409151727.pcvgbfymbr65amy2@ltop.local> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 09, 2018 at 02:54:30PM +0200, Geert Uytterhoeven wrote: > > > > - swim_base = ioremap(res->start, resource_size(res)); > > + swim_base = (struct swim __iomem *)res->start; > > I guess you need a __force to please sparse? Hi, Only pointer-to-pointer conversions may need __force. The logic being if you use an integer type to hold an address this address is typeless anyway and has no address-space, so extra checking is not done in this case and the cast in itself is enough. Cheers, -- Luc