From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752093AbeDJFUV (ORCPT ); Tue, 10 Apr 2018 01:20:21 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:20186 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751595AbeDJFUQ (ORCPT ); Tue, 10 Apr 2018 01:20:16 -0400 From: Philippe Cornu To: Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Rob Herring , "Mark Rutland" , , , CC: Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Alexandre Torgue Subject: [PATCH 2/2] drm/bridge: sii902x: add optional power supplies Date: Tue, 10 Apr 2018 07:19:27 +0200 Message-ID: <20180410051927.8268-3-philippe.cornu@st.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180410051927.8268-1-philippe.cornu@st.com> References: <20180410051927.8268-1-philippe.cornu@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.129.6.58] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-10_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the 3 optional power supplies using the exact description found in the document named "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/sii902x.c | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 60373d7eb220..e17ba6db1ec8 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bridge/sii902x.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -86,6 +87,7 @@ struct sii902x { struct drm_bridge bridge; struct drm_connector connector; struct gpio_desc *reset_gpio; + struct regulator_bulk_data supplies[3]; }; static inline struct sii902x *bridge_to_sii902x(struct drm_bridge *bridge) @@ -392,23 +394,43 @@ static int sii902x_probe(struct i2c_client *client, return PTR_ERR(sii902x->reset_gpio); } + sii902x->supplies[0].supply = "iovcc"; + sii902x->supplies[1].supply = "avcc12"; + sii902x->supplies[2].supply = "cvcc12"; + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(sii902x->supplies), + sii902x->supplies); + if (ret) { + dev_err(dev, "regulator_bulk_get failed\n"); + return ret; + } + + ret = regulator_bulk_enable(ARRAY_SIZE(sii902x->supplies), + sii902x->supplies); + if (ret) { + dev_err(dev, "regulator_bulk_enable failed\n"); + return ret; + } + + usleep_range(10000, 20000); + sii902x_reset(sii902x); ret = regmap_write(sii902x->regmap, SII902X_REG_TPI_RQB, 0x0); if (ret) - return ret; + goto err_disable_regulator; ret = regmap_bulk_read(sii902x->regmap, SII902X_REG_CHIPID(0), &chipid, 4); if (ret) { dev_err(dev, "regmap_read failed %d\n", ret); - return ret; + goto err_disable_regulator; } if (chipid[0] != 0xb0) { dev_err(dev, "Invalid chipid: %02x (expecting 0xb0)\n", chipid[0]); - return -EINVAL; + ret = -EINVAL; + goto err_disable_regulator; } /* Clear all pending interrupts */ @@ -424,7 +446,7 @@ static int sii902x_probe(struct i2c_client *client, IRQF_ONESHOT, dev_name(dev), sii902x); if (ret) - return ret; + goto err_disable_regulator; } sii902x->bridge.funcs = &sii902x_bridge_funcs; @@ -434,6 +456,12 @@ static int sii902x_probe(struct i2c_client *client, i2c_set_clientdata(client, sii902x); return 0; + +err_disable_regulator: + regulator_bulk_disable(ARRAY_SIZE(sii902x->supplies), + sii902x->supplies); + + return ret; } static int sii902x_remove(struct i2c_client *client) @@ -443,6 +471,9 @@ static int sii902x_remove(struct i2c_client *client) drm_bridge_remove(&sii902x->bridge); + regulator_bulk_disable(ARRAY_SIZE(sii902x->supplies), + sii902x->supplies); + return 0; } -- 2.15.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe Cornu Subject: [PATCH 2/2] drm/bridge: sii902x: add optional power supplies Date: Tue, 10 Apr 2018 07:19:27 +0200 Message-ID: <20180410051927.8268-3-philippe.cornu@st.com> References: <20180410051927.8268-1-philippe.cornu@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180410051927.8268-1-philippe.cornu@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yannick Fertre , Philippe Cornu , Alexandre Torgue List-Id: devicetree@vger.kernel.org QWRkIHRoZSAzIG9wdGlvbmFsIHBvd2VyIHN1cHBsaWVzIHVzaW5nIHRoZSBleGFjdCBkZXNjcmlw dGlvbgpmb3VuZCBpbiB0aGUgZG9jdW1lbnQgbmFtZWQKIlNpSTkwMjJBL1NpSTkwMjRBIEhETUkg VHJhbnNtaXR0ZXIgRGF0YSBTaGVldCAoQXVndXN0IDIwMTYpIi4KClNpZ25lZC1vZmYtYnk6IFBo aWxpcHBlIENvcm51IDxwaGlsaXBwZS5jb3JudUBzdC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9zaWk5MDJ4LmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc2lpOTAyeC5jIGIvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9zaWk5MDJ4LmMKaW5kZXggNjAzNzNkN2ViMjIwLi5lMTdiYTZkYjFlYzgg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc2lpOTAyeC5jCisrKyBiL2RyaXZl cnMvZ3B1L2RybS9icmlkZ2Uvc2lpOTAyeC5jCkBAIC0yNCw2ICsyNCw3IEBACiAjaW5jbHVkZSA8 bGludXgvaTJjLmg+CiAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+CiAjaW5jbHVkZSA8bGludXgv cmVnbWFwLmg+CisjaW5jbHVkZSA8bGludXgvcmVndWxhdG9yL2NvbnN1bWVyLmg+CiAKICNpbmNs dWRlIDxkcm0vZHJtUC5oPgogI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgpAQCAt ODYsNiArODcsNyBAQCBzdHJ1Y3Qgc2lpOTAyeCB7CiAJc3RydWN0IGRybV9icmlkZ2UgYnJpZGdl OwogCXN0cnVjdCBkcm1fY29ubmVjdG9yIGNvbm5lY3RvcjsKIAlzdHJ1Y3QgZ3Bpb19kZXNjICpy ZXNldF9ncGlvOworCXN0cnVjdCByZWd1bGF0b3JfYnVsa19kYXRhIHN1cHBsaWVzWzNdOwogfTsK IAogc3RhdGljIGlubGluZSBzdHJ1Y3Qgc2lpOTAyeCAqYnJpZGdlX3RvX3NpaTkwMngoc3RydWN0 IGRybV9icmlkZ2UgKmJyaWRnZSkKQEAgLTM5MiwyMyArMzk0LDQzIEBAIHN0YXRpYyBpbnQgc2lp OTAyeF9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAogCQlyZXR1cm4gUFRSX0VSUihz aWk5MDJ4LT5yZXNldF9ncGlvKTsKIAl9CiAKKwlzaWk5MDJ4LT5zdXBwbGllc1swXS5zdXBwbHkg PSAiaW92Y2MiOworCXNpaTkwMngtPnN1cHBsaWVzWzFdLnN1cHBseSA9ICJhdmNjMTIiOworCXNp aTkwMngtPnN1cHBsaWVzWzJdLnN1cHBseSA9ICJjdmNjMTIiOworCXJldCA9IGRldm1fcmVndWxh dG9yX2J1bGtfZ2V0KGRldiwgQVJSQVlfU0laRShzaWk5MDJ4LT5zdXBwbGllcyksCisJCQkJICAg ICAgc2lpOTAyeC0+c3VwcGxpZXMpOworCWlmIChyZXQpIHsKKwkJZGV2X2VycihkZXYsICJyZWd1 bGF0b3JfYnVsa19nZXQgZmFpbGVkXG4iKTsKKwkJcmV0dXJuIHJldDsKKwl9CisKKwlyZXQgPSBy ZWd1bGF0b3JfYnVsa19lbmFibGUoQVJSQVlfU0laRShzaWk5MDJ4LT5zdXBwbGllcyksCisJCQkJ ICAgIHNpaTkwMngtPnN1cHBsaWVzKTsKKwlpZiAocmV0KSB7CisJCWRldl9lcnIoZGV2LCAicmVn dWxhdG9yX2J1bGtfZW5hYmxlIGZhaWxlZFxuIik7CisJCXJldHVybiByZXQ7CisJfQorCisJdXNs ZWVwX3JhbmdlKDEwMDAwLCAyMDAwMCk7CisKIAlzaWk5MDJ4X3Jlc2V0KHNpaTkwMngpOwogCiAJ cmV0ID0gcmVnbWFwX3dyaXRlKHNpaTkwMngtPnJlZ21hcCwgU0lJOTAyWF9SRUdfVFBJX1JRQiwg MHgwKTsKIAlpZiAocmV0KQotCQlyZXR1cm4gcmV0OworCQlnb3RvIGVycl9kaXNhYmxlX3JlZ3Vs YXRvcjsKIAogCXJldCA9IHJlZ21hcF9idWxrX3JlYWQoc2lpOTAyeC0+cmVnbWFwLCBTSUk5MDJY X1JFR19DSElQSUQoMCksCiAJCQkgICAgICAgJmNoaXBpZCwgNCk7CiAJaWYgKHJldCkgewogCQlk ZXZfZXJyKGRldiwgInJlZ21hcF9yZWFkIGZhaWxlZCAlZFxuIiwgcmV0KTsKLQkJcmV0dXJuIHJl dDsKKwkJZ290byBlcnJfZGlzYWJsZV9yZWd1bGF0b3I7CiAJfQogCiAJaWYgKGNoaXBpZFswXSAh PSAweGIwKSB7CiAJCWRldl9lcnIoZGV2LCAiSW52YWxpZCBjaGlwaWQ6ICUwMnggKGV4cGVjdGlu ZyAweGIwKVxuIiwKIAkJCWNoaXBpZFswXSk7Ci0JCXJldHVybiAtRUlOVkFMOworCQlyZXQgPSAt RUlOVkFMOworCQlnb3RvIGVycl9kaXNhYmxlX3JlZ3VsYXRvcjsKIAl9CiAKIAkvKiBDbGVhciBh bGwgcGVuZGluZyBpbnRlcnJ1cHRzICovCkBAIC00MjQsNyArNDQ2LDcgQEAgc3RhdGljIGludCBz aWk5MDJ4X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCiAJCQkJCQlJUlFGX09ORVNI T1QsIGRldl9uYW1lKGRldiksCiAJCQkJCQlzaWk5MDJ4KTsKIAkJaWYgKHJldCkKLQkJCXJldHVy biByZXQ7CisJCQlnb3RvIGVycl9kaXNhYmxlX3JlZ3VsYXRvcjsKIAl9CiAKIAlzaWk5MDJ4LT5i cmlkZ2UuZnVuY3MgPSAmc2lpOTAyeF9icmlkZ2VfZnVuY3M7CkBAIC00MzQsNiArNDU2LDEyIEBA IHN0YXRpYyBpbnQgc2lpOTAyeF9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAogCWky Y19zZXRfY2xpZW50ZGF0YShjbGllbnQsIHNpaTkwMngpOwogCiAJcmV0dXJuIDA7CisKK2Vycl9k aXNhYmxlX3JlZ3VsYXRvcjoKKwlyZWd1bGF0b3JfYnVsa19kaXNhYmxlKEFSUkFZX1NJWkUoc2lp OTAyeC0+c3VwcGxpZXMpLAorCQkJICAgICAgIHNpaTkwMngtPnN1cHBsaWVzKTsKKworCXJldHVy biByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgc2lpOTAyeF9yZW1vdmUoc3RydWN0IGkyY19jbGllbnQg KmNsaWVudCkKQEAgLTQ0Myw2ICs0NzEsOSBAQCBzdGF0aWMgaW50IHNpaTkwMnhfcmVtb3ZlKHN0 cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpCiAKIAlkcm1fYnJpZGdlX3JlbW92ZSgmc2lpOTAyeC0+ YnJpZGdlKTsKIAorCXJlZ3VsYXRvcl9idWxrX2Rpc2FibGUoQVJSQVlfU0laRShzaWk5MDJ4LT5z dXBwbGllcyksCisJCQkgICAgICAgc2lpOTAyeC0+c3VwcGxpZXMpOworCiAJcmV0dXJuIDA7CiB9 CiAKLS0gCjIuMTUuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==