From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
Arnd Bergmann <arnd@arndb.de>,
Manikanta Pubbisetty <mpubbise@qti.qualcomm.com>,
Anilkumar Kolli <akolli@codeaurora.org>,
Carl Huang <cjhuang@codeaurora.org>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Johannes Berg <johannes.berg@intel.com>,
Maharaja Kennadyrajan <mkenna@codeaurora.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: ath10k: avoid possible string overflow
Date: Tue, 10 Apr 2018 14:28:49 +0000 (UTC) [thread overview]
Message-ID: <20180410142849.EB1DA60F5F@smtp.codeaurora.org> (raw)
In-Reply-To: <20180328220635.3704458-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> The way that 'strncat' is used here raised a warning in gcc-8:
>
> drivers/net/wireless/ath/ath10k/wmi.c: In function 'ath10k_wmi_tpc_stats_final_disp_tables':
> drivers/net/wireless/ath/ath10k/wmi.c:4649:4: error: 'strncat' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
>
> Effectively, this is simply a strcat() but the use of strncat() suggests
> some form of overflow check. Regardless of whether this might actually
> overflow, using strlcat() instead of strncat() avoids the warning and
> makes the code more robust.
>
> Fixes: bc64d05220f3 ("ath10k: debugfs support to get final TPC stats for 10.4 variants")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
6707ba0105a2 ath10k: avoid possible string overflow
--
https://patchwork.kernel.org/patch/10314201/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-04-10 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 22:06 [PATCH] ath10k: avoid possible string overflow Arnd Bergmann
2018-03-28 22:06 ` Arnd Bergmann
2018-04-10 14:28 ` Kalle Valo
2018-04-10 14:28 ` Kalle Valo
2018-04-10 14:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410142849.EB1DA60F5F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=arnd@arndb.de \
--cc=ath10k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=garsilva@embeddedor.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mkenna@codeaurora.org \
--cc=mpubbise@qti.qualcomm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.