From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f60Fs-0003N7-B9 for mharc-grub-devel@gnu.org; Tue, 10 Apr 2018 16:52:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f60Fq-0003Le-6O for grub-devel@gnu.org; Tue, 10 Apr 2018 16:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f60Fl-0003XH-I3 for grub-devel@gnu.org; Tue, 10 Apr 2018 16:52:38 -0400 Received: from boksu.net-space.pl ([185.15.1.105]:37895) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.71) (envelope-from ) id 1f60Fl-0003UV-64 for grub-devel@gnu.org; Tue, 10 Apr 2018 16:52:33 -0400 Received: (from localhost user: 'dkiper' uid#4000 fake: STDIN (dkiper@boksu.net-space.pl)) by router-fw-old.local.net-space.pl id S1835248AbeDJUw2 (ORCPT ); Tue, 10 Apr 2018 22:52:28 +0200 Date: Tue, 10 Apr 2018 22:52:28 +0200 From: Daniel Kiper To: nvinson234@gmail.com Cc: grub-devel@gnu.org Subject: Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files Message-ID: <20180410205228.GB25917@router-fw-old.local.net-space.pl> References: <215c48d12d36aec6c8c2c48a4be325fc743d764c.1523131110.git.nvinson234@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <215c48d12d36aec6c8c2c48a4be325fc743d764c.1523131110.git.nvinson234@gmail.com> User-Agent: Mutt/1.3.28i X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.15.1.105 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 20:52:39 -0000 On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: > Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > partuuid target. Update grub.texi documentation. The following table > shows how GRUB_DISABLE_LINUX_UUID, GRUB_DISABLE_LINUX_PARTUUID, and > initramfs detection interact: > > Initramfs GRUB_DISABLE_LINUX_PARTUUID GRUB_DISABLE_LINUX_UUID Linux Root > detected Set Set ID Method > > False False False part UUID > False False True part UUID > False True False dev name > False True True dev name > True False False fs UUID > True False True part UUID > True True False fs UUID > True True True dev name What will happen if GRUB_DISABLE_LINUX_PARTUUID and/or GRUB_DISABLE_LINUX_UUID are not set? I think that you can avoid that by setting defaults. You do that for GRUB_DISABLE_LINUX_PARTUUID in next patch but GRUB_DISABLE_LINUX_UUID does not have any default. > Signed-off-by: Nicholas Vinson > --- > docs/grub.texi | 10 ++++++++++ > util/grub-mkconfig.in | 3 +++ > util/grub.d/10_linux.in | 18 +++++++++++++++--- Could you update util/grub.d/20_linux_xen.in too? > 3 files changed, 28 insertions(+), 3 deletions(-) > > diff --git a/docs/grub.texi b/docs/grub.texi > index 65b4bbeda..06f0afe45 100644 > --- a/docs/grub.texi > +++ b/docs/grub.texi > @@ -1424,6 +1424,16 @@ the Linux kernel, using a @samp{root=UUID=...} kernel parameter. This is > usually more reliable, but in some cases it may not be appropriate. To > disable the use of UUIDs, set this option to @samp{true}. > > +@item GRUB_DISABLE_LINUX_PARTUUID > +If @command{grub-mkconfig} cannot identify the root filesystem via its > +universally-unique indentifier (UUID), @command{grub-mkconfig} will use the UUID > +of the partition containing the filesystem to identify the root filesystem to > +the Linux kernel via a @samp{root=PARTUUID=...} kernel parameter. This is not > +as reliable as using the filesystem UUID, but is more reliable than using the > +Linux device names. When enabled, this option requires the Linux kernel version s/When enabled, /When enabled, GRUB_DISABLE_LINUX_PARTUUID set to false, / or something like that. Otherwise it is unclear. Daniel