All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 4/4] configs/freescale_imx8mqevk: new defconfig
Date: Tue, 10 Apr 2018 23:26:29 +0200	[thread overview]
Message-ID: <20180410232629.1951a7e9@windsurf> (raw)
In-Reply-To: <CAPP7BN2uRzk-8z-NTNpPe3uiEGUxU6ooKP2gDu0eQQ5eRGtebg@mail.gmail.com>

Hello,

On Tue, 10 Apr 2018 19:31:51 +0200, Erik Larsson wrote:

> > Also, could you split the i.MX8 stuff from the support of the i.MX8 EVK board itself ?
> >
> > I.e adding the genimage.cfg file, and adding imx8-bootloader.prepare.sh
> > should be one patch, and then adding the i.MX8 EVK defconfig and
> > readme.txt should be another patch.
> >
> > Could you rework the last two patches according to those comments ?  
> 
> I've started to rework this and have something that at least works.
> I've moved the generation of imx-boot-imx8mqevk-sd.bin to a separate
> prepare script and tried to separate what is iMX8 general and what is
> imx8mqevk specific in that script. So the gen_imx8_boot() function can
> be removed from post-script.sh. I still need to keep the selection of
> genimage.cfg.template in post-script.sh but instead of checking for
> IMX8M it can check if it's a IMX8 platform. Is it something like that
> you hade in mind?

How are you going to check if it's an IMX8 platform ? For me, the test
on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M to decide which genimage
file to use was fine. What I wanted is:

 (1) Split in different commits the introduction of i.MX8 support and
     the addition of the i.MX8 EVK support. A first commit should
     change the post-image.sh script to add i.MX8 stuff, and separate
     commit should add the defconfig and board/ stuff related to the
     i.MX8 EVK board.

 (2) Split the i.MX8 specific bootloader preparation logic outside of
     the common post-image into a separate script called as a
     post-image script.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-10 21:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10 11:51 [Buildroot] [PATCH v6 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
2018-03-10 11:51 ` [Buildroot] [PATCH v6 1/4] imx-mkimage: new package Erik Larsson
2018-04-09 20:07   ` Thomas Petazzoni
2018-04-10  5:27     ` Erik Larsson
2018-04-10  6:56       ` Thomas Petazzoni
2018-03-10 11:51 ` [Buildroot] [PATCH v6 2/4] freescale-imx: add config option for i.MX8M Erik Larsson
2018-04-09 20:08   ` Thomas Petazzoni
2018-03-10 11:51 ` [Buildroot] [PATCH v6 3/4] firmware-imx: add support for iMX8M firmware Erik Larsson
2018-04-09 20:38   ` Thomas Petazzoni
2018-03-10 11:51 ` [Buildroot] [PATCH v6 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
2018-04-09 20:42   ` Thomas Petazzoni
2018-04-09 20:46     ` Fabio Estevam
2018-04-10  5:37     ` Erik Larsson
2018-04-10 17:31     ` Erik Larsson
2018-04-10 21:26       ` Thomas Petazzoni [this message]
2018-04-11  5:23         ` Erik Larsson
2018-03-28  9:23 ` [Buildroot] [PATCH v6 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180410232629.1951a7e9@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.