From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v5 18/21] ethdev: add private generic device
	iterator
Date: Wed, 11 Apr 2018 10:41:48 +0200
Message-ID: <20180411084148.6jfryfxqg3iwc4ho@bidouze.vm.6wind.com>
References: <cover.1523404469.git.gaetan.rivet@6wind.com>
 <ff2abdc0738191682df7eb462f2eb957fac1e6c4.1523404469.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
 [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 378221B825
 for <dev@dpdk.org>; Wed, 11 Apr 2018 10:42:04 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id z73so913216wrb.0
 for <dev@dpdk.org>; Wed, 11 Apr 2018 01:42:04 -0700 (PDT)
Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.
 [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id m35sm1431713wrm.59.2018.04.11.01.42.02
 for <dev@dpdk.org>
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 11 Apr 2018 01:42:02 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <ff2abdc0738191682df7eb462f2eb957fac1e6c4.1523404469.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Apr 11, 2018 at 02:04:19AM +0200, Gaetan Rivet wrote:
> This iterator can be customized with a comparison function that will
> trigger a stopping condition.
> 
> It can be leveraged to write several different iterators that have
> similar but non-identical purposes.
> 
> It is private to librte_ether.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  lib/librte_ether/Makefile      |  1 +
>  lib/librte_ether/eth_private.c | 32 ++++++++++++++++++++++++++++++++
>  lib/librte_ether/eth_private.h | 26 ++++++++++++++++++++++++++
>  3 files changed, 59 insertions(+)
>  create mode 100644 lib/librte_ether/eth_private.c
>  create mode 100644 lib/librte_ether/eth_private.h
> 
> diff --git a/lib/librte_ether/Makefile b/lib/librte_ether/Makefile
> index c2f2f7d82..2fa133fbc 100644
> --- a/lib/librte_ether/Makefile
> +++ b/lib/librte_ether/Makefile
> @@ -18,6 +18,7 @@ EXPORT_MAP := rte_ethdev_version.map
>  
>  LIBABIVER := 9
>  
> +SRCS-y += eth_private.c
>  SRCS-y += rte_ethdev.c
>  SRCS-y += rte_flow.c
>  SRCS-y += rte_tm.c
> diff --git a/lib/librte_ether/eth_private.c b/lib/librte_ether/eth_private.c
> new file mode 100644
> index 000000000..311c5d6b2
> --- /dev/null
> +++ b/lib/librte_ether/eth_private.c
> @@ -0,0 +1,32 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Gaëtan

Forgot something here.

> + */
> +
> +#include "rte_ethdev.h"
> +#include "eth_private.h"
> +
> +struct rte_eth_dev *
> +eth_find_device(const void *_start, rte_eth_cmp_t cmp,

_start should be of type (const struct rte_eth_dev *), will update this
patch.

Same changes to eth_private.h

-- 
Gaëtan Rivet
6WIND