From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces From: Vinod Koul Message-Id: <20180411094000.GD6014@localhost> Date: Wed, 11 Apr 2018 15:10:01 +0530 To: Baolin Wang Cc: dan.j.williams@intel.com, eric.long@spreadtrum.com, broonie@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBBcHIgMTAsIDIwMTggYXQgMDM6NDY6MDdQTSArMDgwMCwgQmFvbGluIFdhbmcgd3Jv dGU6Cj4gVGhpcyBwYXRjaCBhZGRzIHRoZSAnZGV2aWNlX2NvbmZpZycgYW5kICdkZXZpY2VfcHJl cF9zbGF2ZV9zZycgaW50ZXJmYWNlcwo+IGZvciB1c2VycyB0byBjb25maWd1cmUgRE1BLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IEJhb2xpbiBXYW5nIDxiYW9saW4ud2FuZ0BsaW5hcm8ub3JnPgo+IC0t LQo+ICBkcml2ZXJzL2RtYS9zcHJkLWRtYS5jIHwgICA0OCArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQ4IGluc2VydGlv bnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEvc3ByZC1kbWEuYyBiL2RyaXZlcnMv ZG1hL3NwcmQtZG1hLmMKPiBpbmRleCBmODAzOGRlLi5jOTIzZmIwIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZG1hL3NwcmQtZG1hLmMKPiArKysgYi9kcml2ZXJzL2RtYS9zcHJkLWRtYS5jCj4gQEAg LTg2OSw2ICs4NjksNTIgQEAgc3RhdGljIGludCBzcHJkX2RtYV9jb25maWcoc3RydWN0IGRtYV9j aGFuICpjaGFuLCBzdHJ1Y3Qgc3ByZF9kbWFfZGVzYyAqc2Rlc2MsCj4gIAlyZXR1cm4gdmNoYW5f dHhfcHJlcCgmc2NoYW4tPnZjLCAmc2Rlc2MtPnZkLCBmbGFncyk7Cj4gIH0KPiAgCj4gK3N0YXRp YyBzdHJ1Y3QgZG1hX2FzeW5jX3R4X2Rlc2NyaXB0b3IgKgo+ICtzcHJkX2RtYV9wcmVwX3NsYXZl X3NnKHN0cnVjdCBkbWFfY2hhbiAqY2hhbiwgc3RydWN0IHNjYXR0ZXJsaXN0ICpzZ2wsCj4gKwkJ ICAgICAgIHVuc2lnbmVkIGludCBzZ2xlbiwgZW51bSBkbWFfdHJhbnNmZXJfZGlyZWN0aW9uIGRp ciwKPiArCQkgICAgICAgdW5zaWduZWQgbG9uZyBmbGFncywgdm9pZCAqY29udGV4dCkKPiArewo+ ICsJc3RydWN0IHNwcmRfZG1hX2NobiAqc2NoYW4gPSB0b19zcHJkX2RtYV9jaGFuKGNoYW4pOwo+ ICsJc3RydWN0IHNwcmRfZG1hX2NvbmZpZyAqc2xhdmVfY2ZnID0gJnNjaGFuLT5zbGF2ZV9jZmc7 Cj4gKwlzdHJ1Y3Qgc3ByZF9kbWFfZGVzYyAqc2Rlc2M7Cj4gKwlzdHJ1Y3Qgc2NhdHRlcmxpc3Qg KnNnOwo+ICsJaW50IHJldCwgaTsKPiArCj4gKwkvKiBUT0RPOiBub3cgd2Ugb25seSBzdXBwb3J0 IG9uZSBzZyBmb3IgZWFjaCBETUEgY29uZmlndXJhdGlvbi4gKi8KPiArCWlmICghaXNfc2xhdmVf ZGlyZWN0aW9uKHNsYXZlX2NmZy0+Y29uZmlnLmRpcmVjdGlvbikgfHwgc2dsZW4gPiAxKQoKdGhl IHNsYXZlIGRpcmVjdGlvbiBjaGVjayBzZWVtcyB3cm9uZyB0byBtZS4gLmRldmljZV9jb25maWcg c2hhbGwgZ2l2ZSB5b3UKZG1hX3NsYXZlX2NvbmZpZy4gWW91IHNob3VsZCBjaGVjayBoZXJlIGlm IGRpciBwYXNzZWQgaXMgc2xhdmUgb3Igbm90LiBJZgp5b3Ugd2FudCB0byBjaGVjayBwYXJhbWV0 ZXJzIGluIHNsYXZlX2NvbmZpZyB0aGVuIHBsZWFzZSB1c2UgLmRldmljZV9jb25maWcKCj4gKwkJ cmV0dXJuIE5VTEw7Cj4gKwo+ICsJc2Rlc2MgPSBremFsbG9jKHNpemVvZigqc2Rlc2MpLCBHRlBf Tk9XQUlUKTsKPiArCWlmICghc2Rlc2MpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJZm9yX2Vh Y2hfc2coc2dsLCBzZywgc2dsZW4sIGkpIHsKPiArCQlpZiAoc2xhdmVfY2ZnLT5jb25maWcuZGly ZWN0aW9uID09IERNQV9NRU1fVE9fREVWKQo+ICsJCQlzbGF2ZV9jZmctPmNvbmZpZy5zcmNfYWRk ciA9IHNnX2RtYV9hZGRyZXNzKHNnKTsKCk5vcGUgc2xhdmVfY29uZmlnIHNwZWNpZmllcyBwZXJp cGhlcmFsIGFkZHJlc3MgYW5kIG5vdCBtZW1vcnkgb25lIHBhc3NlZCBoZXJlCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbeDKJff (ORCPT ); Wed, 11 Apr 2018 05:35:35 -0400 Received: from mga07.intel.com ([134.134.136.100]:62743 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbeDKJfe (ORCPT ); Wed, 11 Apr 2018 05:35:34 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,435,1517904000"; d="scan'208";a="45282895" Date: Wed, 11 Apr 2018 15:10:01 +0530 From: Vinod Koul To: Baolin Wang Cc: dan.j.williams@intel.com, eric.long@spreadtrum.com, broonie@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Message-ID: <20180411094000.GD6014@localhost> References: <0a9fa618bd74e74c135ebee2e40b30d361c1d905.1523346135.git.baolin.wang@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a9fa618bd74e74c135ebee2e40b30d361c1d905.1523346135.git.baolin.wang@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 10, 2018 at 03:46:07PM +0800, Baolin Wang wrote: > This patch adds the 'device_config' and 'device_prep_slave_sg' interfaces > for users to configure DMA. > > Signed-off-by: Baolin Wang > --- > drivers/dma/sprd-dma.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > index f8038de..c923fb0 100644 > --- a/drivers/dma/sprd-dma.c > +++ b/drivers/dma/sprd-dma.c > @@ -869,6 +869,52 @@ static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc, > return vchan_tx_prep(&schan->vc, &sdesc->vd, flags); > } > > +static struct dma_async_tx_descriptor * > +sprd_dma_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, > + unsigned int sglen, enum dma_transfer_direction dir, > + unsigned long flags, void *context) > +{ > + struct sprd_dma_chn *schan = to_sprd_dma_chan(chan); > + struct sprd_dma_config *slave_cfg = &schan->slave_cfg; > + struct sprd_dma_desc *sdesc; > + struct scatterlist *sg; > + int ret, i; > + > + /* TODO: now we only support one sg for each DMA configuration. */ > + if (!is_slave_direction(slave_cfg->config.direction) || sglen > 1) the slave direction check seems wrong to me. .device_config shall give you dma_slave_config. You should check here if dir passed is slave or not. If you want to check parameters in slave_config then please use .device_config > + return NULL; > + > + sdesc = kzalloc(sizeof(*sdesc), GFP_NOWAIT); > + if (!sdesc) > + return NULL; > + > + for_each_sg(sgl, sg, sglen, i) { > + if (slave_cfg->config.direction == DMA_MEM_TO_DEV) > + slave_cfg->config.src_addr = sg_dma_address(sg); Nope slave_config specifies peripheral address and not memory one passed here -- ~Vinod