From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53968 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751960AbeDKKSG (ORCPT ); Wed, 11 Apr 2018 06:18:06 -0400 Date: Wed, 11 Apr 2018 12:17:59 +0200 From: Jesper Dangaard Brouer To: Quentin Monnet Cc: brouer@redhat.com, daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, linux-doc@vger.kernel.org, linux-man@vger.kernel.org, John Fastabend Subject: Re: [RFC bpf-next v2 8/8] bpf: add documentation for eBPF helpers (58-64) Message-ID: <20180411121759.4191e267@redhat.com> In-Reply-To: <20180410144157.4831-9-quentin.monnet@netronome.com> References: <20180410144157.4831-1-quentin.monnet@netronome.com> <20180410144157.4831-9-quentin.monnet@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 10 Apr 2018 15:41:57 +0100 Quentin Monnet wrote: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 7343af4196c8..db090ad03626 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -1250,6 +1250,51 @@ union bpf_attr { > * Return > * 0 on success, or a negative error in case of failure. > * > + * int bpf_redirect_map(struct bpf_map *map, u32 key, u64 flags) > + * Description > + * Redirect the packet to the endpoint referenced by *map* at > + * index *key*. Depending on its type, his *map* can contain > + * references to net devices (for forwarding packets through other > + * ports), or to CPUs (for redirecting XDP frames to another CPU; > + * but this is not fully implemented as of this writing). Stating that CPUMAP redirect "is not fully implemented" is confusing. The issue is that CPUMAP only works for "native" XDP. What about saying: "[...] or to CPUs (for redirecting XDP frames to another CPU; but this is only implemented for native XDP as of this writing)" -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 9FC5C7DE78 for ; Wed, 11 Apr 2018 10:18:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbeDKKSI (ORCPT ); Wed, 11 Apr 2018 06:18:08 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53968 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751960AbeDKKSG (ORCPT ); Wed, 11 Apr 2018 06:18:06 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB52D10D425; Wed, 11 Apr 2018 10:18:05 +0000 (UTC) Received: from localhost (ovpn-200-37.brq.redhat.com [10.40.200.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 33B1E8444A; Wed, 11 Apr 2018 10:18:00 +0000 (UTC) Date: Wed, 11 Apr 2018 12:17:59 +0200 From: Jesper Dangaard Brouer To: Quentin Monnet Cc: brouer@redhat.com, daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, linux-doc@vger.kernel.org, linux-man@vger.kernel.org, John Fastabend Subject: Re: [RFC bpf-next v2 8/8] bpf: add documentation for eBPF helpers (58-64) Message-ID: <20180411121759.4191e267@redhat.com> In-Reply-To: <20180410144157.4831-9-quentin.monnet@netronome.com> References: <20180410144157.4831-1-quentin.monnet@netronome.com> <20180410144157.4831-9-quentin.monnet@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 11 Apr 2018 10:18:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 11 Apr 2018 10:18:05 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'brouer@redhat.com' RCPT:'' Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, 10 Apr 2018 15:41:57 +0100 Quentin Monnet wrote: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 7343af4196c8..db090ad03626 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -1250,6 +1250,51 @@ union bpf_attr { > * Return > * 0 on success, or a negative error in case of failure. > * > + * int bpf_redirect_map(struct bpf_map *map, u32 key, u64 flags) > + * Description > + * Redirect the packet to the endpoint referenced by *map* at > + * index *key*. Depending on its type, his *map* can contain > + * references to net devices (for forwarding packets through other > + * ports), or to CPUs (for redirecting XDP frames to another CPU; > + * but this is not fully implemented as of this writing). Stating that CPUMAP redirect "is not fully implemented" is confusing. The issue is that CPUMAP only works for "native" XDP. What about saying: "[...] or to CPUs (for redirecting XDP frames to another CPU; but this is only implemented for native XDP as of this writing)" -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html