From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net v2 2/6] bnxt_en: do not allow wildcard matches for L2 flows Date: Wed, 11 Apr 2018 14:19:28 -0700 Message-ID: <20180411141928.491dfb6f@cakuba.netronome.com> References: <1523461818-15774-1-git-send-email-michael.chan@broadcom.com> <1523461818-15774-3-git-send-email-michael.chan@broadcom.com> <20180411114303.6f927c45@cakuba.netronome.com> <20180411203152.GD33938@C02RW35GFVH8.dhcp.broadcom.net> <20180411205014.GE33938@C02RW35GFVH8.dhcp.broadcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , Netdev To: Michael Chan , Andy Gospodarek Return-path: Received: from mx3.wp.pl ([212.77.101.9]:16710 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754979AbeDKVTk (ORCPT ); Wed, 11 Apr 2018 17:19:40 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 11 Apr 2018 13:55:11 -0700, Michael Chan wrote: > On Wed, Apr 11, 2018 at 1:50 PM, Andy Gospodarek wrote: > > On Wed, Apr 11, 2018 at 01:41:31PM -0700, Michael Chan wrote: > > True, but I'm not sure that tc_cls_common_offload is used in all cases. > > Take red_offload() as one of those. > > For Flower, we know we have the extack pointer in > tc_cls_common_offload struct and we can use it to set the netlink > error message. The point is that we don't have to modify > ndo_setup_tc(). Yes, the extack is actually only populated when skip_sw is specified to avoid warning users who don't care about offloads. Flower offloads don't go via .ndo_setup_tc but TC block callbacks. But one day we will hopefully find a reasonable way to pass extack to qdisc offloads as well.. FWIW your driver is actually already using extack under the veil of tc_cls_can_offload_and_chain0() :)