From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3253174-1523477763-2-6260453361914784902 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523477762; b=UyF5u4nx2B0QMSegEZIcrWWVEcWeaJvNEBwVjvp3NJ3IbiRIeO SYjtu2D4NLsvYqZ8S8/P+I2RtkMI/y4PcxvcVWRq4VUdVs3mLv6TdD4gpd8TNSnp scPbXFpkT/K1uCmfOnz4yLmWgKHiHdHeokGX9qBzeNDxFcIxiUEr9Xn3m4VJBYbW uFh69kE3Qr4ghzx/o5C8yCMCBkXjwzDig5bLIfIrpxyv1xF6iBYbzUPhlJZCEL4g gafK0c0pPuq+by/kLvKe3med33fVGlwPGjVsaAW3bQ+EphA4kKIspGJlS2shSElG kzuZYl4oM3BSNJlGSKuwvBbmEk6W9M0Sa6sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=fm2; t=1523477762; bh=eZt5xgsI/AACZsUKhc1kIIOdN8qLpE HAVp5I3rZXhY4=; b=s0v3ZaxF4oDTUjrZSBSKsYxANjuBGMagqslbo3fwv91zm8 URXUfnlXuEq2dH6+nSP/n7L8GBAyIOtuxOiCxiR4ClTZVcDb/PKNZ1q+dG+aTf6S nNC6zqBZY54wPhhTXsh7bnCJpb9vf1GkgSu9GZtsFl2jQoL56e7vXbcfM6hwbeA5 eu8WOtAWu3aLY3yqDDKO4xSdEW3bhv98wal5UI2GpqDqRXxXeLrHmVzft0x8HTCR HRTs1Ul7JbopMX6vROe8axdNjgi7j/aGNC5VdAhLNJ0QpqVdlsKGMYVhHZPxPMLS 5+QPQvd6uxWiJ7bjylinQhxXb6IryCavsYY6vEPg== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfP4cl6Hmbf3y4ZnqKWLzN1UElYDYaMdcYileo7yDauYJOt55Pi6xJeE8xFYxjdnUZeVIQKQn0SbTFM/p28IByJA6wrg5LRJcpDIM4Ri47yCKTE8c9wI8 gpt5AlOloWvpjkEk+uFAWLNXtrQfvWOQs9EIamUrk40E7SmMtvbmFvHwGJWj72OgQejsMZUCCZx0HVrFLMPkQ8Z+P4PXuiLth1jifQPQOWCo/N1M54swKEyH X-CM-Analysis: v=2.3 cv=JLoVTfCb c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=yPCof4ZbAAAA:8 a=fk1lIlRQAAAA:8 a=yMhMjlubAAAA:8 a=ag1SF4gXAAAA:8 a=8EMWpIwaYYN3MEKlIKMA:9 a=QEXdDO2ut3YA:10 a=U75ogvRika4pmaD_UPO0:22 a=Yupwre4RP9_Eg_Bd0iYG:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932484AbeDKSxG (ORCPT ); Wed, 11 Apr 2018 14:53:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33610 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932401AbeDKSxE (ORCPT ); Wed, 11 Apr 2018 14:53:04 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Corey Minyard , Sasha Levin Subject: [PATCH 4.9 017/310] ipmi_ssif: unlock on allocation failure Date: Wed, 11 Apr 2018 20:32:36 +0200 Message-Id: <20180411183623.036019183@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180411183622.305902791@linuxfoundation.org> References: <20180411183622.305902791@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit cf9806f32ef63b745f2486e0dbb2ac21f4ca44f0 ] We should unlock and re-enable IRQs if this allocation fails. Fixes: 259307074bfc ("ipmi: Add SMBus interface driver (SSIF) ") Signed-off-by: Dan Carpenter Signed-off-by: Corey Minyard Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/char/ipmi/ipmi_ssif.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -409,6 +409,7 @@ static void start_event_fetch(struct ssi msg = ipmi_alloc_smi_msg(); if (!msg) { ssif_info->ssif_state = SSIF_NORMAL; + ipmi_ssif_unlock_cond(ssif_info, flags); return; } @@ -431,6 +432,7 @@ static void start_recv_msg_fetch(struct msg = ipmi_alloc_smi_msg(); if (!msg) { ssif_info->ssif_state = SSIF_NORMAL; + ipmi_ssif_unlock_cond(ssif_info, flags); return; }