From: jwcart2@tycho.nsa.gov (James Carter)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH 08/13] Remove undeclared identifiers from shorewall interfaces
Date: Wed, 11 Apr 2018 14:56:38 -0400 [thread overview]
Message-ID: <20180411185639.23547-9-jwcart2@tycho.nsa.gov> (raw)
In-Reply-To: <20180411185639.23547-1-jwcart2@tycho.nsa.gov>
Both shorewall_read_pid_files() and shorewall_rw_pid_files() use the
undeclared type shorewall_var_run_t. Removed statements referring to this
type and marked the interfaces as deprecated because they no longer do
anything useful.
Neither interface is called in the policy.
Signed-off-by: James Carter <jwcart2@tycho.nsa.gov>
---
shorewall.if | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/shorewall.if b/shorewall.if
index 108ce75..119ba27 100644
--- a/shorewall.if
+++ b/shorewall.if
@@ -62,38 +62,28 @@ interface(`shorewall_read_config',`
## <summary>
## Read shorewall pid files.
## </summary>
-## <param name="domain">
+## <param name="domain" unused="true">
## <summary>
## Domain allowed access.
## </summary>
## </param>
#
interface(`shorewall_read_pid_files',`
- gen_require(`
- type shorewall_var_run_t;
- ')
-
- files_search_pids($1)
- read_files_pattern($1, shorewall_var_run_t, shorewall_var_run_t)
+ refpolicywarn(`$0($*) has been deprecated')
')
#######################################
## <summary>
## Read and write shorewall pid files.
## </summary>
-## <param name="domain">
+## <param name="domain" unused="true">
## <summary>
## Domain allowed access.
## </summary>
## </param>
#
interface(`shorewall_rw_pid_files',`
- gen_require(`
- type shorewall_var_run_t;
- ')
-
- files_search_pids($1)
- rw_files_pattern($1, shorewall_var_run_t, shorewall_var_run_t)
+ refpolicywarn(`$0($*) has been deprecated')
')
######################################
--
2.13.6
next prev parent reply other threads:[~2018-04-11 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 18:56 [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 01/13] Remove unnecessary semicolons James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 02/13] Mark unused parameter as unused James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 03/13] Add unused parameter and mark " James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 04/13] Remove use of undeclared attribute from portage.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 05/13] Move use of httpd_t from mojomojo.te to apache.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 06/13] Move use of sendmail_exec_t from sendmail.te to mta.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 07/13] Fix typos in identifier names James Carter
2018-04-11 18:56 ` James Carter [this message]
2018-04-11 18:56 ` [refpolicy] [PATCH 09/13] Fix interfaces that use an undeclared identifier James Carter
2018-04-12 22:47 ` [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib Chris PeBenito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411185639.23547-9-jwcart2@tycho.nsa.gov \
--to=jwcart2@tycho.nsa.gov \
--cc=refpolicy@oss.tresys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.