From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbeDLOQx (ORCPT ); Thu, 12 Apr 2018 10:16:53 -0400 Received: from muru.com ([72.249.23.125]:36396 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753095AbeDLOQo (ORCPT ); Thu, 12 Apr 2018 10:16:44 -0400 Date: Thu, 12 Apr 2018 07:16:39 -0700 From: Tony Lindgren To: Keerthy Cc: linus.walleij@linaro.org, grygorii.strashko@ti.com, t-kristo@ti.com, Russ.Dill@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, ssantosh@kernel.org, haojian.zhuang@linaro.org, linux-arm-kernel@lists.infradead.org, d-gerlach@ti.com, Russ Dill Subject: Re: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context. Message-ID: <20180412141639.GV5700@atomide.com> References: <1523505239-16229-1-git-send-email-j-keerthy@ti.com> <1523505239-16229-9-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523505239-16229-9-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Keerthy [180412 03:56]: > From: Russ Dill > > This adds a pair of context save/restore functions to save/restore the > state of a set of pinctrl registers. This simplifies some of the AM33XX > PM code as some of the pinctrl registers are lost when the per power > domain loses power. The pincrtl code can perform the necessary > save/restore. So where's the patch adding callers to this code? If this cannot be done from regular driver suspend/resume calls, this probably should be done from cpu_pm notifiers CPU_PM_ENTER and CPU_PM_EXIT. We should also do the same for GPIO BTW. BTW, the subject line is wrong here, it should be "pinctrl" :) Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 12 Apr 2018 07:16:39 -0700 Subject: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context. In-Reply-To: <1523505239-16229-9-git-send-email-j-keerthy@ti.com> References: <1523505239-16229-1-git-send-email-j-keerthy@ti.com> <1523505239-16229-9-git-send-email-j-keerthy@ti.com> Message-ID: <20180412141639.GV5700@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, * Keerthy [180412 03:56]: > From: Russ Dill > > This adds a pair of context save/restore functions to save/restore the > state of a set of pinctrl registers. This simplifies some of the AM33XX > PM code as some of the pinctrl registers are lost when the per power > domain loses power. The pincrtl code can perform the necessary > save/restore. So where's the patch adding callers to this code? If this cannot be done from regular driver suspend/resume calls, this probably should be done from cpu_pm notifiers CPU_PM_ENTER and CPU_PM_EXIT. We should also do the same for GPIO BTW. BTW, the subject line is wrong here, it should be "pinctrl" :) Regards, Tony