From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753072AbeDLVWH (ORCPT ); Thu, 12 Apr 2018 17:22:07 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35560 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbeDLVWF (ORCPT ); Thu, 12 Apr 2018 17:22:05 -0400 Date: Thu, 12 Apr 2018 14:22:03 -0700 From: Matthew Wilcox To: Ross Zwisler Cc: Andrew Morton , Matthew Wilcox , LKML , Linux MM , linux-fsdevel , Ryusuke Konishi , linux-nilfs@vger.kernel.org Subject: Re: [PATCH v9 07/61] xarray: Add the xa_lock to the radix_tree_root Message-ID: <20180412212203.GD18364@bombadil.infradead.org> References: <20180313132639.17387-1-willy@infradead.org> <20180313132639.17387-8-willy@infradead.org> <20180412211036.GB18364@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 12, 2018 at 03:16:23PM -0600, Ross Zwisler wrote: > On Thu, Apr 12, 2018 at 3:10 PM, Matthew Wilcox wrote: > > On Thu, Apr 12, 2018 at 02:59:32PM -0600, Ross Zwisler wrote: > >> This is causing build breakage in the radix tree test suite in the > >> current linux/master: > >> > >> ./linux/../../../../include/linux/idr.h: In function ‘idr_init_base’: > >> ./linux/../../../../include/linux/radix-tree.h:129:2: warning: > >> implicit declaration of function ‘spin_lock_init’; did you mean > >> ‘spinlock_t’? [-Wimplicit-function-declaration] > > > > Argh. That was added two patches later in > > "xarray: Add definition of struct xarray": > > > > diff --git a/tools/include/linux/spinlock.h b/tools/include/linux/spinlock.h > > index b21b586b9854..4ec4d2cbe27a 100644 > > --- a/tools/include/linux/spinlock.h > > +++ b/tools/include/linux/spinlock.h > > @@ -6,8 +6,9 @@ > > #include > > > > #define spinlock_t pthread_mutex_t > > -#define DEFINE_SPINLOCK(x) pthread_mutex_t x = PTHREAD_MUTEX_INITIALIZER; > > +#define DEFINE_SPINLOCK(x) pthread_mutex_t x = PTHREAD_MUTEX_INITIALIZER > > #define __SPIN_LOCK_UNLOCKED(x) (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER > > +#define spin_lock_init(x) pthread_mutex_init(x, NULL) > > > > #define spin_lock_irqsave(x, f) (void)f, pthread_mutex_lock(x) > > #define spin_unlock_irqrestore(x, f) (void)f, pthread_mutex_unlock(x) > > > > I didn't pick up that it was needed this early on in the patch series. > > Hmmm..I don't know if it's a patch ordering issue, because this > happens with the current linux/master where presumably all the patches > are present? No, Andrew only merged the first 8 or so because of lack of review of the remaining patches. Even though I cc'd people as hard as I could. Including you. :-P You could, for example, review the DAX patches ... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id 8D6426B0005 for ; Thu, 12 Apr 2018 17:22:06 -0400 (EDT) Received: by mail-pf0-f199.google.com with SMTP id z20so3584509pfn.11 for ; Thu, 12 Apr 2018 14:22:06 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id p91-v6si4003575plb.705.2018.04.12.14.22.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Apr 2018 14:22:05 -0700 (PDT) Date: Thu, 12 Apr 2018 14:22:03 -0700 From: Matthew Wilcox Subject: Re: [PATCH v9 07/61] xarray: Add the xa_lock to the radix_tree_root Message-ID: <20180412212203.GD18364@bombadil.infradead.org> References: <20180313132639.17387-1-willy@infradead.org> <20180313132639.17387-8-willy@infradead.org> <20180412211036.GB18364@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Ross Zwisler Cc: Andrew Morton , Matthew Wilcox , LKML , Linux MM , linux-fsdevel , Ryusuke Konishi , linux-nilfs@vger.kernel.org On Thu, Apr 12, 2018 at 03:16:23PM -0600, Ross Zwisler wrote: > On Thu, Apr 12, 2018 at 3:10 PM, Matthew Wilcox wrote: > > On Thu, Apr 12, 2018 at 02:59:32PM -0600, Ross Zwisler wrote: > >> This is causing build breakage in the radix tree test suite in the > >> current linux/master: > >> > >> ./linux/../../../../include/linux/idr.h: In function a??idr_init_basea??: > >> ./linux/../../../../include/linux/radix-tree.h:129:2: warning: > >> implicit declaration of function a??spin_lock_inita??; did you mean > >> a??spinlock_ta??? [-Wimplicit-function-declaration] > > > > Argh. That was added two patches later in > > "xarray: Add definition of struct xarray": > > > > diff --git a/tools/include/linux/spinlock.h b/tools/include/linux/spinlock.h > > index b21b586b9854..4ec4d2cbe27a 100644 > > --- a/tools/include/linux/spinlock.h > > +++ b/tools/include/linux/spinlock.h > > @@ -6,8 +6,9 @@ > > #include > > > > #define spinlock_t pthread_mutex_t > > -#define DEFINE_SPINLOCK(x) pthread_mutex_t x = PTHREAD_MUTEX_INITIALIZER; > > +#define DEFINE_SPINLOCK(x) pthread_mutex_t x = PTHREAD_MUTEX_INITIALIZER > > #define __SPIN_LOCK_UNLOCKED(x) (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER > > +#define spin_lock_init(x) pthread_mutex_init(x, NULL) > > > > #define spin_lock_irqsave(x, f) (void)f, pthread_mutex_lock(x) > > #define spin_unlock_irqrestore(x, f) (void)f, pthread_mutex_unlock(x) > > > > I didn't pick up that it was needed this early on in the patch series. > > Hmmm..I don't know if it's a patch ordering issue, because this > happens with the current linux/master where presumably all the patches > are present? No, Andrew only merged the first 8 or so because of lack of review of the remaining patches. Even though I cc'd people as hard as I could. Including you. :-P You could, for example, review the DAX patches ...