From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs/187: fix ftype brokenness
Date: Fri, 13 Apr 2018 14:14:08 +0800 [thread overview]
Message-ID: <20180413061408.GH2932@desktop> (raw)
In-Reply-To: <20180411160809.GA13697@magnolia>
On Wed, Apr 11, 2018 at 09:08:09AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> This test requires XFS_SB_VERSION_MOREBITSBIT to be zero. ftype (which
> is now enabled by default) causes this to be set, so detect it in mkfs
> and disable it.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/187 | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/xfs/187 b/tests/xfs/187
> index 07ef3ae..e1a8ce9 100755
> --- a/tests/xfs/187
> +++ b/tests/xfs/187
> @@ -70,8 +70,14 @@ export MOUNT_OPTIONS=""
> # lazysb, attr2 and other feature bits are held in features2 and will require
> # morebitsbit on So test with lazysb and without it to see if the morebitsbit is
> # okay etc. If the mkfs defaults change, these need to change as well.
> -export MKFS_NO_LAZY="-m crc=0 -l lazy-count=0 -i projid32bit=0"
> -export MKFS_LAZY="-m crc=0 -l lazy-count=1 -i projid32bit=0"
> +MKFS_NO_LAZY="-m crc=0 -l lazy-count=0 -i projid32bit=0"
> +MKFS_LAZY="-m crc=0 -l lazy-count=1 -i projid32bit=0"
> +
> +# Detect ftype
I'd put the reason of detecting ftype support in comments here. I can
fix it on commit.
Thanks,
Eryu
> +if _scratch_mkfs --help 2>&1 | grep -q "ftype="; then
> + MKFS_NO_LAZY="$MKFS_NO_LAZY -n ftype=0"
> + MKFS_LAZY="$MKFS_LAZY -n ftype=0"
> +fi
>
> # Make sure that when we think we are testing with morebits off
> # that we really are.
next prev parent reply other threads:[~2018-04-13 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 16:08 [PATCH] xfs/187: fix ftype brokenness Darrick J. Wong
2018-04-13 6:14 ` Eryu Guan [this message]
2018-04-13 23:37 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413061408.GH2932@desktop \
--to=guaneryu@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.